You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:17:25 UTC
[GitHub] [camel-website] psingh587 opened a new pull request #234: Added an
anchor tag to allow the users to reach the top of the page
psingh587 opened a new pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234
-For pages with large contents, once we scrolled all the way down at the bottom of the page, we had to scroll up again to reach the top of the page. So to make the part easier, i added anchor tag at the bottom of the page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399219665
##########
File path: layouts/partials/footer.html
##########
@@ -46,3 +51,4 @@
</body>
</html>
+
Review comment:
Nitpick: empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r400448427
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -71,7 +71,7 @@ footer .footer dl dd {
margin-left: 80%;
}
-@media screen and (max-width: 640px) {
+@media screen and (max-width: 1181px) {
Review comment:
So, Should I work in the previous breakpoint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604538733
> We need the link to top of the page in the documentation as well and the link-checker needs to be configured.
@zregvart
For files under documentation, every page is hard-coded. So I will have to change each and every file under it to achieve this. Is this the only way to do this, or am I missing out on something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-602001167
Hi @oscerd
i checked the shell script details. it showed : anchor not found from security/index.html to security/index.html#top
Could you please guide how to eradicate this error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-603416940
> Doesn't a link to #does-not-exist always take you to the top of the page? Unless this is a standard technique in web design that I don't know about, I think it would be better to find a solution that doesn't rely on what I'd term exception handling. For instance does <a href="#"... work?
Hi @djencks
Yes sir, I might have missed that part while learning. <a href="#"></a>
this works too. I will try to come up with a better solution then. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604507574
> @psingh587 we need the same change in the Antora UI layout here (just add the top of the page markup):
>
> https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/antora-ui-camel/src/partials/footer-content.hbs#L1
@zregvart
*This particular change comes under <div class="edit".. and not under <footer*
This is how the footer-content.hbs begins
` <footer>
<div class="footer">
<figure class="logo">
<img src="{{siteRootPath}}/_/img/logo-d.svg" class="logo-small mt-60" alt="Apache Camel Logo" aria-label="white silhouette of a camel in front of a sand dune">
</figure>`
and this is how the footer.html begins.
`
<div class="edit"> <a title="Improve this document, receive free virtual hugs ♥" href="https://github.com/apache/camel-website/edit/master/content/{{ .File.Path | replaceRE "^/" "" }}">Edit this Page
</a>
<a href="#top" title="Reach the top of the page">Back to top</a>
</div>
<footer>
<div class="footer">
<figure class="logo">`
I guess there is no requirement to make any changes there. Please correct me if I'm wrong . the changes are visible on my localhost with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-605525120
@zregvart
Is it okay to add a smooth scrolling effect when we click on Back To Top?
Rather than going to top at once, it would smoothly travel all its way up. In my opinion, this would be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-606211217
> @psingh587 I have a concern about accessibility of smooth scrolling, read [this](https://css-tricks.com/smooth-scrolling-accessibility/).
@zregvart agreed with the fact that for longer pages, there would be a lot of content to be scrolled up at once and that could cause a dizzy effect for the user. Maybe, then I should drop this idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] djencks commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
djencks commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-603412771
Doesn't a link to #does-not-exist always take you to the top of the page? Unless this is a standard technique in web design that I don't know about, I think it would be better to find a solution that doesn't rely on what I'd term exception handling. For instance does <a href="#"... work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-607161658
I have created a fresh PR #301 for this and it includes all the requested changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-602001167
Hi @oscerd
i checked the shell script details. it showed : anchor not found from security/index.html to security/index.html#top and other errors as that
Could you please guide how to eradicate this error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399618509
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -71,7 +71,7 @@ footer .footer dl dd {
margin-left: 80%;
}
-@media screen and (max-width: 640px) {
+@media screen and (max-width: 1181px) {
Review comment:
@zregvart
this I had to do because, as can be seen in the picture above, one block was stashing above the another. Now with this ,they don't and this particular thing applies for <div class="edit" only so it does not affect anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604510917
> We also need to configure the [link-checker](https://github.com/timaschew/link-checker) to ignore links that target `#top`. I think we can add `--url-ignore='#top'` here:
>
> https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/package.json#L13
Here in this, Do I have to add this particular line `--url-ignore='#top'` within the same lines as of link-checker like this?
"check:links": "link-checker --disable-external --mkdocs --allow-hash-href public --url-ignore='#top'",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 closed pull request #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 closed pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-603416940
> Doesn't a link to #does-not-exist always take you to the top of the page? Unless this is a standard technique in web design that I don't know about, I think it would be better to find a solution that doesn't rely on what I'd term exception handling. For instance does <a href="#"... work?
Hi @djencks
Yes sir, I might have missed that part while learning. <a href="#"> this works too. I will try to come up with a better solution then. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 removed a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 removed a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604538733
> We need the link to top of the page in the documentation as well and the link-checker needs to be configured.
@zregvart
For files under documentation, every page is hard-coded. So I will have to change each and every file under it to achieve this. Is this the only way to do this, or am I missing out on something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 edited a comment on issue #234: Added an
anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-603416940
> Doesn't a link to #does-not-exist always take you to the top of the page? Unless this is a standard technique in web design that I don't know about, I think it would be better to find a solution that doesn't rely on what I'd term exception handling. For instance does <a href="#"... work?
Hi @djencks
Yes sir, I might have missed that part while learning. <a href="#"..
this works too. I will try to come up with a better solution then. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399218814
##########
File path: package.json
##########
@@ -1,6 +1,6 @@
{
"version": "1.0.0-SNAPSHOT",
- "license": "Apache-2.0",
+ "license": "Apache-2.0",
Review comment:
Nitpick: trailing whitespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r400446673
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -71,7 +71,7 @@ footer .footer dl dd {
margin-left: 80%;
}
-@media screen and (max-width: 640px) {
+@media screen and (max-width: 1181px) {
Review comment:
There needs to be a better way, adding media breakpoints is not a good solution. With any change we do, say we increase/decrease the font size we need to test at every breakpoint, the total number of tests is layouts*breakpoints, so it makes it very difficult for us to test, that's why we can't be adding new breakpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-608520142
@zregvart
Should I record this PR in Outreachy website or leave it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399618509
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -71,7 +71,7 @@ footer .footer dl dd {
margin-left: 80%;
}
-@media screen and (max-width: 640px) {
+@media screen and (max-width: 1181px) {
Review comment:
@zregvart
this I had to do because, as can be seen in the picture above, the blocks were stashing above each other. Now with this ,they don't and this particular thing applies for <div class="edit" only so it does not affect anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399218923
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"preview:antora": "antora --clean --fetch antora-playbook.yml",
"preview:hugo": "hugo server -D",
"check:xref": "antora --generator @antora/xref-validator antora-playbook.yml",
- "check:links": "link-checker --disable-external --mkdocs --allow-hash-href public",
+ "check:links": "link-checker --disable-external --mkdocs --allow-hash-href public --url-ignore='#top'",
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604538733
> We need the link to top of the page in the documentation as well and the link-checker needs to be configured.
@zregvart
For files under documentation, every page is hard-coded. So I will have to change the each and every file under it to achieve this. Is this the only way to do this, or am I missing out on something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r400447138
##########
File path: antora-playbook.yml
##########
@@ -45,6 +45,9 @@ content:
- url: git@github.com:apache/camel-spring-boot.git
branches: master
start_path: docs
+ - url: git@github.com:apache/camel-karaf.git
+ branches: master
+ start_path: docs
Review comment:
This looks like an unrelated change, can you rebase to pick up the current playbook?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-606206575
@psingh587 I have a concern about accessibility of smooth scrolling, read [this](https://css-tricks.com/smooth-scrolling-accessibility/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604400795
We also need to configure the [link-checker](https://github.com/timaschew/link-checker) to ignore links that target `#top`. I think we can add `--url-ignore='#top'` here:
https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/package.json#L13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-603405285
> This changes the layout in Hugo, we need a corresponding change in the Antora layouts as well. I don't see where the element with `id=top` is present so that's missing as well, without it this will not function.
Hi @zregvart ,
about the id issue, actually I have tried this one in my local machine. It works perfectly. Upon clicking it, it takes to the top of the page without having an id="top". I wonder why, but it does work here.
Shall i make specific changes in antora layouts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604507574
> @psingh587 we need the same change in the Antora UI layout here (just add the top of the page markup):
>
> https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/antora-ui-camel/src/partials/footer-content.hbs#L1
@zregvart
*This particular change comes under <div class="edit".. and not under <footer*
This is how the footer-content.hbs begins
` <footer>
<div class="footer">
<figure class="logo">
<img src="{{siteRootPath}}/_/img/logo-d.svg" class="logo-small mt-60" alt="Apache Camel Logo" aria-label="white silhouette of a camel in front of a sand dune">
</figure>`
and this is how the footer.html begins.
`
<div class="edit"> <a title="Improve this document, receive free virtual hugs ♥" href="https://github.com/apache/camel-website/edit/master/content/{{ .File.Path | replaceRE "^/" "" }}">Edit this Page
</a>
<a href="#top" title="Reach the top of the page">Back to top</a>
</div>
<footer>
<div class="footer">
<figure class="logo">`
I guess there is no requirement to make any changes there. Please correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-608524089
@psingh587 please record this, you both raised the issue did the first implementation and reviewed the second one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#234: Added an anchor tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#discussion_r399618509
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -71,7 +71,7 @@ footer .footer dl dd {
margin-left: 80%;
}
-@media screen and (max-width: 640px) {
+@media screen and (max-width: 1181px) {
Review comment:
this I had to because, as can be seen, in the picture above, the blocks were stashing above each other. Now with this they don't and this particular thing applies for <div class="edit" only so it does not affect anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #234: Added an anchor
tag to allow the users to reach the top of the page
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #234: Added an anchor tag to allow the users to reach the top of the page
URL: https://github.com/apache/camel-website/pull/234#issuecomment-604399634
Today I learned about `#top` not needing to be defined in the markup. Thanks for that @psingh587 and @djencks. I've found a note in the examples [here](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a) to attest to that.
@psingh587 we need the same change in the Antora UI layout here (just add the top of the page markup):
https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/antora-ui-camel/src/partials/footer-content.hbs#L1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services