[GitHub] [apisix] AlinsRan commented on a diff in pull request #9291: feat: support consuming specified cost in the limit count function

["AlinsRan (via GitHub)" <gi...@apache.org>]

AlinsRan commented on code in PR #9291:
URL: https://github.com/apache/apisix/pull/9291#discussion_r1173228255


##########
apisix/plugins/limit-count/init.lua:
##########
@@ -20,7 +20,6 @@ local tab_insert = table.insert
 local ipairs = ipairs
 local pairs = pairs
 
-local plugin_name = "limit-count"

Review Comment:
   The plugin name will not change.
   It seems unnecessary to repeatedly pass between multiple functions and concatenate strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org