You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/29 17:57:35 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #910: Fix sama5d3x-ek/nxwm build break
xiaoxiang781216 opened a new pull request #910:
URL: https://github.com/apache/incubator-nuttx/pull/910
## Summary
The below commit try to fix the issue by skip compling adc:
```
commit ab2e24b42b8010b169b61eb73ddc6f105c3c5111
Author: Xiang Xiao <xi...@xiaomi.com>
Date: Wed Apr 29 14:15:24 2020 +0800
sama5d3x-ek/nxwm: Fix error: 'g_adcdev' undeclared
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
```
but the touchscreen used by nxwm depend on adc, so the right fix is resolving the compiler error with adc enable.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #910: Fix sama5d3x-ek/nxwm build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #910:
URL: https://github.com/apache/incubator-nuttx/pull/910#issuecomment-621375812
nxstyle complain CONFIG_SAMA5D3xEK_TSD_DEVMINOR, but SAMA5D3xEK is used spread sama5 arch:
boards/arm/sama5/sama5d3x-ek/src/sam_touchscreen.c:108:30: error: Mixed case identifier found
boards/arm/sama5/sama5d3x-ek/src/sam_touchscreen.c:112:11: error: Mixed case identifier found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org