[GitHub] [arrow-rs] sunchao commented on a change in pull request #1432: Replace Arc with Box in ArrowArray for FFI structs

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #1432:
URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r826506993



##########
File path: arrow/src/array/array.rs
##########
@@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw(
     schema: *const ffi::FFI_ArrowSchema,
 ) -> Result<ArrayRef> {
     let array = ffi::ArrowArray::try_from_raw(array, schema)?;
-    let data = ArrayData::try_from(array)?;
+    let data = ArrayData::try_from(&array)?;
+    // Avoid dropping the `Box` pointers and trigger the `release` mechanism.
+    let _ = ffi::ArrowArray::into_raw(array);

Review comment:
       I agree it'd be nice if we can retain the previous API. When the `release` on the input `array` and `schema` are supposed to be called previously?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org