You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/10/15 17:32:34 UTC
[PR] fix(server)!: derive session timeout from heartbeat.interval [iggy]
hubcio opened a new pull request, #4562:
URL: https://github.com/apache/iggy/pull/4562
Two settings timed out a silent client. The heartbeat verifier
evicted after 1.2 x heartbeat.interval, while the session report
and the lease used consumer_group.session_timeout. No validator
related them, so a client silent for two 30s timeouts lost its
session even under a 60s heartbeat interval, and the [heartbeat]
docs described only the verifier.
Remove consumer_group.session_timeout, and refuse to boot while it
is still set, so a configured timeout cannot change unnoticed. The
lease, the activity window of the session report and the verifier
now all use 1.2 x heartbeat.interval, also with heartbeat checks
off, and the validators check that window. At the defaults a
closed connection ends after about 36s and a silent one after
about 72s. A heartbeat.interval of 17.7s or less now needs a
shorter consumer_group.heartbeat_interval. Specs that pinned an 8s
timeout set a 7s interval, and those that close their members turn
the checks off so idle open members keep their sessions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server)!: derive session timeout from heartbeat.interval [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4562:
URL: https://github.com/apache/iggy/pull/4562#issuecomment-6200510254
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4562?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 89.03%. Comparing base ([`12cc1f3`](https://app.codecov.io/gh/apache/iggy/commit/12cc1f3cf3ef85debcb97421d5b9933dc18e2d8d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f599ee1`](https://app.codecov.io/gh/apache/iggy/commit/f599ee170583cb8bc93e2aeb0a1ad9b8665a5737?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4562 +/- ##
============================================
- Coverage 89.49% 89.03% -0.46%
Complexity 1784 1784
============================================
Files 1330 1330
Lines 284420 284413 -7
Branches 242863 242856 -7
============================================
- Hits 254551 253241 -1310
- Misses 24227 25571 +1344
+ Partials 5642 5601 -41
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.74% <100.00%> (-0.02%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.71% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.42% <ø> (-12.95%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.43% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.84% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.12% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.86% <ø> (-0.03%)` | :arrow_down: |
| [C++ SDK](https://app.codecov.io/gh/apache/iggy/pull/4562/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.44% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4562?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/configs/src/common/defaults.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fcommon%2Fdefaults.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9jb21tb24vZGVmYXVsdHMucnM=) | `100.00% <ø> (ø)` | |
| [core/configs/src/common/displays.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fcommon%2Fdisplays.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9jb21tb24vZGlzcGxheXMucnM=) | `100.00% <ø> (ø)` | |
| [core/configs/src/common/server.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fcommon%2Fserver.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9jb21tb24vc2VydmVyLnJz) | `100.00% <100.00%> (ø)` | |
| [core/configs/src/server\_config/server.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fserver.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL3NlcnZlci5ycw==) | `93.21% <ø> (ø)` | |
| [core/configs/src/server\_config/validators.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_config%2Fvalidators.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfY29uZmlnL3ZhbGlkYXRvcnMucnM=) | `94.75% <100.00%> (-0.03%)` | :arrow_down: |
| [core/server/src/boot/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fboot%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2Jvb3QvbW9kLnJz) | `86.86% <100.00%> (+0.03%)` | :arrow_up: |
| [core/server/src/dispatch/host.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fdispatch%2Fhost.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2Rpc3BhdGNoL2hvc3QucnM=) | `97.61% <100.00%> (-0.16%)` | :arrow_down: |
| [core/server/src/dispatch/session\_ops.rs](https://app.codecov.io/gh/apache/iggy/pull/4562?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fdispatch%2Fsession_ops.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2Rpc3BhdGNoL3Nlc3Npb25fb3BzLnJz) | `91.92% <100.00%> (ø)` | |
... and [64 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4562/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server)!: derive session timeout from heartbeat.interval [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4562:
URL: https://github.com/apache/iggy/pull/4562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org