[jira] [Commented] (HADOOP-10431) Change visibility of KeyStore KeyVersion/Metadata/Options constructor and methods to public

["Aaron T. Myers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958349#comment-13958349 ] 

Aaron T. Myers commented on HADOOP-10431:
-----------------------------------------

I think this comment is wrong for {{KeyProvider#getVersion}}:

{code}
+   * Get the version from the given versionName. Converts "/aaa/bbb/3" to
+   * 3.
{code}

Shouldn't the example instead be  "/aaa/bbb@3" ? Likewise for {{getBaseName}}, but this patch doesn't introduce that error.

+1 pending this issue being addressed and Jenkins.

> Change visibility of KeyStore KeyVersion/Metadata/Options constructor and methods to public
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10431
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10431
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-10431.patch
>
>
> Making KeyVersion/Metadata/Options constructor and methods public will facilitate {{KeyProvider}} implementations to use those classes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)