You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 21:46:48 UTC
[GitHub] [nifi] emiliosetiadarma opened a new pull request, #6313: NIFI-9451 add input character set property for PutEmail and additiona…
emiliosetiadarma opened a new pull request, #6313:
URL: https://github.com/apache/nifi/pull/6313
…l tests
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-9451](https://issues.apache.org/jira/browse/NIFI-9451)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [x] JDK 11
- [x] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6313:
URL: https://github.com/apache/nifi/pull/6313#issuecomment-1251305012
Will review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6313:
URL: https://github.com/apache/nifi/pull/6313#issuecomment-1255781113
I verified that the change fixed the encoding issue I saw with attached files. I think that should do it, +1 will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
URL: https://github.com/apache/nifi/pull/6313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6313:
URL: https://github.com/apache/nifi/pull/6313#issuecomment-1255764005
Just a note, if you have changes made as a result of a review, commit the change as an additional commit and don't force push. That way the changes made will be tracked in the PR. The committer will merge the commits for you when pushing to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6313: NIFI-9451 add input character set property for PutEmail and additiona…
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6313:
URL: https://github.com/apache/nifi/pull/6313#issuecomment-1254603682
I tested this out, was able to send emails just fine. One thing I had an issue with was other languages. I used Big5 encoding and Chinese characters (http://ash.jp/code/cn/big5tbl.htm) and found that it did come through in the email message content but not in the email attachment. It looks like the character encoding might be getting minced somewhere and might be worth verifying with a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org