[GitHub] [spark] chenzhx commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

[GitBox <gi...@apache.org>]

chenzhx commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r866474987


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -200,6 +201,43 @@ class V2ExpressionBuilder(
       } else {
         None
       }
+    case substring: Substring =>
+      val childrenExpressions = substring.children.flatMap(generateExpression(_))
+      if (childrenExpressions.length == substring.children.length) {
+        Some(new GeneralScalarExpression("SUBSTRING",
+          childrenExpressions.toArray[V2Expression]))
+      } else {
+        None
+      }
+    case Upper(child) => generateExpression(child)
+      .map(v => new GeneralScalarExpression("UPPER", Array[V2Expression](v)))
+    case Lower(child) => generateExpression(child)
+      .map(v => new GeneralScalarExpression("LOWER", Array[V2Expression](v)))
+    case translate: StringTranslate =>
+      val childrenExpressions = translate.children.flatMap(generateExpression(_))
+      if (childrenExpressions.length == translate.children.length) {
+        Some(new GeneralScalarExpression("TRANSLATE",
+          childrenExpressions.toArray[V2Expression]))
+      } else {
+        None
+      }
+    case trim: String2TrimExpression =>
+      val childrenExpressions = trim.children.flatMap(generateExpression(_))
+      if (childrenExpressions.length == trim.children.length) {
+        Some(new GeneralScalarExpression("TRIM",
+          LiteralValue(UTF8String.fromString(trim.direction), VarcharType(0)) +:

Review Comment:
   StringType will add single quotes to LEADING into 'LEADING'.
   And the query result is wrong.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org