You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/24 20:04:04 UTC
[jira] [Commented] (CURATOR-225) Add a new mode ErrorMode.KEEP
[ https://issues.apache.org/jira/browse/CURATOR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599843#comment-14599843 ]
ASF GitHub Bot commented on CURATOR-225:
----------------------------------------
GitHub user zzcoder opened a pull request:
https://github.com/apache/curator/pull/85
CURATOR-225: Added new ErrorMode value KEEP.
Added ErrorMode.KEEP. Created a new test-case testKeepMode() to make sure it works.
If the new mode is not used, the code should work as is so the impact of this change is very limited.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zzcoder/curator master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 035eefc316d84093be9090ceff15d4ac8a90fcdc
Author: Zhihong Zhang <zh...@pixia.com>
Date: 2015-06-24T17:55:59Z
CURATOR-225: Added new ErrorMode value KEEP.
----
> Add a new mode ErrorMode.KEEP
> -----------------------------
>
> Key: CURATOR-225
> URL: https://issues.apache.org/jira/browse/CURATOR-225
> Project: Apache Curator
> Issue Type: New Feature
> Components: Framework
> Affects Versions: 2.8.0
> Environment: Windows 7/Java 8
> Reporter: Zhihong Zhang
> Priority: Critical
> Labels: curator, locking, queue
>
> When locking is used and consumer throws exception, there are currently 2 modes, REQUEUE and DELETE. In our use-cases, the items in the queue need to keep in the same FIFO order, even in case of the error. A 3rd mode is needed to keep the queue order intact.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)