[GitHub] [airflow] ashb commented on a change in pull request #11854: Use packaging.version, not semver module for version comparisons

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #11854:
URL: https://github.com/apache/airflow/pull/11854#discussion_r512021251



##########
File path: provider_packages/prepare_provider_packages.py
##########
@@ -880,16 +881,10 @@ def check_if_release_version_ok(
             else:
                 current_release_version = "0.0.1"  # TODO: replace with maintained version
     if previous_release_version:
-        if backport_packages:
-            if previous_release_version > current_release_version:
-                print(f"The release {current_release_version} must be not less than "
-                      f"{previous_release_version} - last release for the package", file=sys.stderr)
-                sys.exit(2)
-        else:
-            if semver.compare(previous_release_version, current_release_version) > 0:

Review comment:
       Using packaging.version we don't need to handle CalVer separately anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org