You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 20:31:47 UTC
[GitHub] [arrow] kou opened a new pull request, #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
kou opened a new pull request, #13087:
URL: https://github.com/apache/arrow/pull/13087
The following cases return wrong result:
* statistics_no_minmax.Equals(statistics_no_minmax):
This must returns true but false is returned.
* statistics_minmax.Equals(statistics_minmax):
This must returns true but false is returned.
* statistics_minmax1.Equals(statistics_minmax2) where
statistics_minmax1 and statistics_minmax2 have different minmax:
This must returns false but true is returned.
Note that parquet::Statistics::Equals() was introduced by
https://github.com/apache/arrow/pull/8507 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13087:
URL: https://github.com/apache/arrow/pull/13087#issuecomment-1119988291
https://issues.apache.org/jira/browse/ARROW-16487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
Posted by GitBox <gi...@apache.org>.
kou closed pull request #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
URL: https://github.com/apache/arrow/pull/13087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
Posted by GitBox <gi...@apache.org>.
emkornfield commented on PR #13087:
URL: https://github.com/apache/arrow/pull/13087#issuecomment-1120237179
+1 from me. Nice find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13087: ARROW-16487: [C++][Parquet] Fix parquet::Statistics::Equals() with minmax
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13087:
URL: https://github.com/apache/arrow/pull/13087#issuecomment-1124347850
Benchmark runs are scheduled for baseline = 7bfc7320285174beca11256e6258c99a208ce4b7 and contender = 0015ce31c85ad098695913bef377e5467ecf1ebc. 0015ce31c85ad098695913bef377e5467ecf1ebc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fb1aaf665a194dc78672050cf2fc355c...e75df72ad46c4ef0a6959e9d9381fefd/)
[Finished :arrow_down:0.66% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8e82c4a7a588402796ec389cacca564a...844002b4d1f44473a30e946600c31e57/)
[Finished :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8e73cae0c5c4444e9cb4a5338e73ce38...8a1242b55e3e433b8b29460d7b8d8b89/)
[Finished :arrow_down:0.28% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/59cf9dd2fde74fc894bfe47e71b93ff1...3fd21078e3f048219b723ac33681a130/)
Buildkite builds:
[Finished] [`0015ce31` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/728)
[Finished] [`0015ce31` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/725)
[Finished] [`0015ce31` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/715)
[Finished] [`0015ce31` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/730)
[Finished] [`7bfc7320` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/727)
[Finished] [`7bfc7320` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/724)
[Finished] [`7bfc7320` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/714)
[Finished] [`7bfc7320` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/729)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org