You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adrian Crum <ad...@sandglass-software.com> on 2015/06/20 18:56:30 UTC

Re: svn commit: r1686651 - /ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml

This commit generates this error:

2015-06-20 09:42:56,054 |delegator-startup-1  |ModelViewEntity 
      |E| [OrderItemQuantityReportGroupByProduct]: 
[ModelViewEntity.populateFields] ERROR: could not find ModelField for 
entity name: ItemIssuanceQuantitySum and field: issuedDateTime


Adrian Crum
Sandglass Software
www.sandglass-software.com

On 6/20/2015 9:28 AM, diveshdutta@apache.org wrote:
> Author: diveshdutta
> Date: Sat Jun 20 16:28:21 2015
> New Revision: 1686651
>
> URL: http://svn.apache.org/r1686651
> Log:
> [OFBIZ-4559] Fixed issue: InventoryWorker.getOutstandingProductQuantities returns inaccurate results when there are multiple ItemIssuances for an order, created new view entity called ItemIssuanceQuantitySum. This view entity will have sum of issued item grouped by orderItem of Order. Then this view entity is used in OrderItemQuantityReportGroupByProduct view entity instead of ItemIssuance entity. By doing this, we get accurate results.
>
> Modified:
>      ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>
> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml?rev=1686651&r1=1686650&r2=1686651&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml (original)
> +++ ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml Sat Jun 20 16:28:21 2015
> @@ -836,13 +836,22 @@ under the License.
>           <key-map field-name="inventoryItemId"/>
>         </relation>
>       </view-entity>
> +    <view-entity entity-name="ItemIssuanceQuantitySum"
> +            package-name="org.ofbiz.order.order"
> +            never-cache="true"
> +            title="Sum item issuance quantity to use directly in OrderItemQuantityReportGroupByItem and OrderItemQuantityReportGroupByProduct entities">
> +      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
> +      <alias entity-alias="II" name="issuedQuantitySum" field="quantity" function="sum"/>
> +      <alias entity-alias="II" name="orderId" field="orderId" group-by="true"/>
> +      <alias entity-alias="II" name="orderItemSeqId" field="orderItemSeqId" group-by="true"/>
> +    </view-entity>
>       <view-entity entity-name="OrderItemQuantityReportGroupByItem"
>               package-name="org.ofbiz.order.order"
>               never-cache="true"
>               title="Reports quantity ordered, issued and open by item for OrderItems.">
>         <member-entity entity-alias="OH" entity-name="OrderHeader"/>
>         <member-entity entity-alias="OI" entity-name="OrderItem"/>
> -      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
> +      <member-entity entity-alias="II" entity-name="ItemIssuanceQuantitySum"/>
>         <alias entity-alias="OH" name="productStoreId" group-by="false"/>
>         <alias entity-alias="OH" name="orderId" group-by="true"/>
>         <alias entity-alias="OH" name="orderTypeId" group-by="false"/>
> @@ -860,12 +869,12 @@ under the License.
>                 <complex-alias-field entity-alias="OI" field="cancelQuantity" default-value="0"/>
>             </complex-alias>
>         </alias>
> -      <alias entity-alias="II" name="quantityIssued" field="quantity" function="sum"/>
> -      <alias entity-alias="OI" name="quantityOpen" function="sum">
> +      <alias entity-alias="II" name="quantityIssued" field="issuedQuantitySum" function="min" />
> +      <alias entity-alias="OI" name="quantityOpen" function="sum" >
>             <complex-alias operator="-">
>                 <complex-alias-field entity-alias="OI" field="quantity" default-value="0"/>
>                 <complex-alias-field entity-alias="OI" field="cancelQuantity" default-value="0"/>
> -              <complex-alias-field entity-alias="II" field="quantity" default-value="0"/>
> +              <complex-alias-field entity-alias="II" field="issuedQuantitySum" default-value="0"/>
>             </complex-alias>
>         </alias>
>         <view-link entity-alias="OI" rel-entity-alias="OH">
> @@ -886,7 +895,7 @@ under the License.
>               title="Reports quantity ordered, issued and open by product for OrderItems.">
>         <member-entity entity-alias="OH" entity-name="OrderHeader"/>
>         <member-entity entity-alias="OI" entity-name="OrderItem"/>
> -      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
> +      <member-entity entity-alias="II" entity-name="ItemIssuanceQuantitySum"/>
>         <alias entity-alias="OH" name="orderTypeId" group-by="true"/>
>         <alias entity-alias="OH" name="orderStatusId" field="statusId" group-by="false"/>
>         <alias entity-alias="OH" name="orderDate" group-by="false"/>
> @@ -899,12 +908,12 @@ under the License.
>                 <complex-alias-field entity-alias="OI" field="cancelQuantity" default-value="0"/>
>             </complex-alias>
>         </alias>
> -      <alias entity-alias="II" name="quantityIssued" field="quantity" function="sum"/>
> +      <alias entity-alias="II" name="quantityIssued" field="issuedQuantitySum" function="min"/>
>         <alias entity-alias="OI" name="quantityOpen" function="sum">
>             <complex-alias operator="-">
>                 <complex-alias-field entity-alias="OI" field="quantity" default-value="0"/>
>                 <complex-alias-field entity-alias="OI" field="cancelQuantity" default-value="0"/>
> -              <complex-alias-field entity-alias="II" field="quantity" default-value="0"/>
> +              <complex-alias-field entity-alias="II" field="issuedQuantitySum" default-value="0"/>
>             </complex-alias>
>         </alias>
>         <view-link entity-alias="OI" rel-entity-alias="OH">
>
>

Re: svn commit: r1686651 - /ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml

Posted by Divesh Dutta <di...@hotwaxsystems.com>.
Thanks Adrian for reporting this. I am looking into this and will get back
as soon as possible.

Thanks
--
Divesh Dutta.

On Sat, Jun 20, 2015 at 10:26 PM, Adrian Crum <
adrian.crum@sandglass-software.com> wrote:

> This commit generates this error:
>
> 2015-06-20 09:42:56,054 |delegator-startup-1  |ModelViewEntity      |E|
> [OrderItemQuantityReportGroupByProduct]: [ModelViewEntity.populateFields]
> ERROR: could not find ModelField for entity name: ItemIssuanceQuantitySum
> and field: issuedDateTime
>
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
>
> On 6/20/2015 9:28 AM, diveshdutta@apache.org wrote:
>
>> Author: diveshdutta
>> Date: Sat Jun 20 16:28:21 2015
>> New Revision: 1686651
>>
>> URL: http://svn.apache.org/r1686651
>> Log:
>> [OFBIZ-4559] Fixed issue: InventoryWorker.getOutstandingProductQuantities
>> returns inaccurate results when there are multiple ItemIssuances for an
>> order, created new view entity called ItemIssuanceQuantitySum. This view
>> entity will have sum of issued item grouped by orderItem of Order. Then
>> this view entity is used in OrderItemQuantityReportGroupByProduct view
>> entity instead of ItemIssuance entity. By doing this, we get accurate
>> results.
>>
>> Modified:
>>      ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>>
>> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml?rev=1686651&r1=1686650&r2=1686651&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>> (original)
>> +++ ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml Sat Jun
>> 20 16:28:21 2015
>> @@ -836,13 +836,22 @@ under the License.
>>           <key-map field-name="inventoryItemId"/>
>>         </relation>
>>       </view-entity>
>> +    <view-entity entity-name="ItemIssuanceQuantitySum"
>> +            package-name="org.ofbiz.order.order"
>> +            never-cache="true"
>> +            title="Sum item issuance quantity to use directly in
>> OrderItemQuantityReportGroupByItem and
>> OrderItemQuantityReportGroupByProduct entities">
>> +      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
>> +      <alias entity-alias="II" name="issuedQuantitySum" field="quantity"
>> function="sum"/>
>> +      <alias entity-alias="II" name="orderId" field="orderId"
>> group-by="true"/>
>> +      <alias entity-alias="II" name="orderItemSeqId"
>> field="orderItemSeqId" group-by="true"/>
>> +    </view-entity>
>>       <view-entity entity-name="OrderItemQuantityReportGroupByItem"
>>               package-name="org.ofbiz.order.order"
>>               never-cache="true"
>>               title="Reports quantity ordered, issued and open by item
>> for OrderItems.">
>>         <member-entity entity-alias="OH" entity-name="OrderHeader"/>
>>         <member-entity entity-alias="OI" entity-name="OrderItem"/>
>> -      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
>> +      <member-entity entity-alias="II"
>> entity-name="ItemIssuanceQuantitySum"/>
>>         <alias entity-alias="OH" name="productStoreId" group-by="false"/>
>>         <alias entity-alias="OH" name="orderId" group-by="true"/>
>>         <alias entity-alias="OH" name="orderTypeId" group-by="false"/>
>> @@ -860,12 +869,12 @@ under the License.
>>                 <complex-alias-field entity-alias="OI"
>> field="cancelQuantity" default-value="0"/>
>>             </complex-alias>
>>         </alias>
>> -      <alias entity-alias="II" name="quantityIssued" field="quantity"
>> function="sum"/>
>> -      <alias entity-alias="OI" name="quantityOpen" function="sum">
>> +      <alias entity-alias="II" name="quantityIssued"
>> field="issuedQuantitySum" function="min" />
>> +      <alias entity-alias="OI" name="quantityOpen" function="sum" >
>>             <complex-alias operator="-">
>>                 <complex-alias-field entity-alias="OI" field="quantity"
>> default-value="0"/>
>>                 <complex-alias-field entity-alias="OI"
>> field="cancelQuantity" default-value="0"/>
>> -              <complex-alias-field entity-alias="II" field="quantity"
>> default-value="0"/>
>> +              <complex-alias-field entity-alias="II"
>> field="issuedQuantitySum" default-value="0"/>
>>             </complex-alias>
>>         </alias>
>>         <view-link entity-alias="OI" rel-entity-alias="OH">
>> @@ -886,7 +895,7 @@ under the License.
>>               title="Reports quantity ordered, issued and open by product
>> for OrderItems.">
>>         <member-entity entity-alias="OH" entity-name="OrderHeader"/>
>>         <member-entity entity-alias="OI" entity-name="OrderItem"/>
>> -      <member-entity entity-alias="II" entity-name="ItemIssuance"/>
>> +      <member-entity entity-alias="II"
>> entity-name="ItemIssuanceQuantitySum"/>
>>         <alias entity-alias="OH" name="orderTypeId" group-by="true"/>
>>         <alias entity-alias="OH" name="orderStatusId" field="statusId"
>> group-by="false"/>
>>         <alias entity-alias="OH" name="orderDate" group-by="false"/>
>> @@ -899,12 +908,12 @@ under the License.
>>                 <complex-alias-field entity-alias="OI"
>> field="cancelQuantity" default-value="0"/>
>>             </complex-alias>
>>         </alias>
>> -      <alias entity-alias="II" name="quantityIssued" field="quantity"
>> function="sum"/>
>> +      <alias entity-alias="II" name="quantityIssued"
>> field="issuedQuantitySum" function="min"/>
>>         <alias entity-alias="OI" name="quantityOpen" function="sum">
>>             <complex-alias operator="-">
>>                 <complex-alias-field entity-alias="OI" field="quantity"
>> default-value="0"/>
>>                 <complex-alias-field entity-alias="OI"
>> field="cancelQuantity" default-value="0"/>
>> -              <complex-alias-field entity-alias="II" field="quantity"
>> default-value="0"/>
>> +              <complex-alias-field entity-alias="II"
>> field="issuedQuantitySum" default-value="0"/>
>>             </complex-alias>
>>         </alias>
>>         <view-link entity-alias="OI" rel-entity-alias="OH">
>>
>>
>>