You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/10 12:56:11 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer
fgerlits opened a new pull request, #1384:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1384
https://issues.apache.org/jira/browse/MINIFICPP-1885
If you run `win_build_vs.bat` with e.g. the new `/SCRIPTING` option, then the scripting extension will be included in the installer, as before, but now de-selected by default in the installation dialog. You can add it by selecting it during installation.
Most of the extensions newly supported by `win_build_vs.bat` do not currently compile on Windows. This will be addressed in later pull requests.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1384:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1384#discussion_r942470335
##########
win_build_vs.bat:
##########
@@ -66,6 +81,21 @@ for %%x in (%*) do (
if [%%~x] EQU [/N] set build_nanofi=ON
if [%%~x] EQU [/O] set build_opencv=ON
if [%%~x] EQU [/PR] set build_prometheus=ON
+ if [%%~x] EQU [/BUSTACHE] set enable_bustache=ON
+ if [%%~x] EQU [/COAP] set enable_coap=ON
+ if [%%~x] EQU [/ENCRYPT_CONFIG] set enable_encrypt_config=ON
+ if [%%~x] EQU [/GPS] set enable_gps=ON
+ if [%%~x] EQU [/LUA_SCRIPTING] set enable_lua_scripting=ON
+ if [%%~x] EQU [/MQTT] set enable_mqtt=ON
+ if [%%~x] EQU [/OPC] set enable_opc=ON
+ if [%%~x] EQU [/OPENWSMAN] set enable_openwsman=ON
+ if [%%~x] EQU [/OPS] set enable_ops=ON
+ if [%%~x] EQU [/PCAP] set enable_pcap=ON
+ if [%%~x] EQU [/PYTHON] set enable_python=ON
Review Comment:
I would prefer to exclude python from here. Our entire ENABLE_PYTHON is confusing, since it only seems to enable some nanofi python support, and it depends on nanofi, but when I looked into the code, it didn't seem to do really anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer
URL: https://github.com/apache/nifi-minifi-cpp/pull/1384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer
Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1384:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1384#discussion_r942595395
##########
win_build_vs.bat:
##########
@@ -66,6 +81,21 @@ for %%x in (%*) do (
if [%%~x] EQU [/N] set build_nanofi=ON
if [%%~x] EQU [/O] set build_opencv=ON
if [%%~x] EQU [/PR] set build_prometheus=ON
+ if [%%~x] EQU [/BUSTACHE] set enable_bustache=ON
+ if [%%~x] EQU [/COAP] set enable_coap=ON
+ if [%%~x] EQU [/ENCRYPT_CONFIG] set enable_encrypt_config=ON
+ if [%%~x] EQU [/GPS] set enable_gps=ON
+ if [%%~x] EQU [/LUA_SCRIPTING] set enable_lua_scripting=ON
+ if [%%~x] EQU [/MQTT] set enable_mqtt=ON
+ if [%%~x] EQU [/OPC] set enable_opc=ON
+ if [%%~x] EQU [/OPENWSMAN] set enable_openwsman=ON
+ if [%%~x] EQU [/OPS] set enable_ops=ON
+ if [%%~x] EQU [/PCAP] set enable_pcap=ON
+ if [%%~x] EQU [/PYTHON] set enable_python=ON
Review Comment:
good point, I've removed it in 5f4f51ae70eb6e6ff6b0f23e900fe192a5e7b5d3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org