You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/03/03 12:31:03 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
HyukjinKwon opened a new pull request, #40267:
URL: https://github.com/apache/spark/pull/40267
### What changes were proposed in this pull request?
This PR proposes to add `toSeq` to work around Scala 2.13 build at `getCrcValues`.
### Why are the changes needed?
The build in the master branch fails in Scala 2.13 build:
```
[error] /home/runner/work/spark/spark/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala:87:11: type mismatch;
[error] found : scala.collection.mutable.Buffer[Long]
[error] required: Seq[Long]
[error] .map(_.toLong)
[error] ^
```
https://github.com/apache/spark/actions/runs/4323142317/jobs/7546408812
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40267:
URL: https://github.com/apache/spark/pull/40267#issuecomment-1453547362
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40267:
URL: https://github.com/apache/spark/pull/40267#issuecomment-1453468505
Thanks! Let me merge after https://github.com/HyukjinKwon/spark/actions/runs/4323411173/jobs/7547000388. Should take less then 20 mins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40267:
URL: https://github.com/apache/spark/pull/40267#issuecomment-1453467412
merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40267:
URL: https://github.com/apache/spark/pull/40267#issuecomment-1453464858
cc @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40267: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
URL: https://github.com/apache/spark/pull/40267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org