You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/26 02:45:19 UTC

[GitHub] [skywalking] hanahmily opened a new issue, #8948: [Bug] Unit of measure's interval should stop at Day

hanahmily opened a new issue, #8948:
URL: https://github.com/apache/skywalking/issues/8948

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   BanyanDB (apache/skywalking-banyandb)
   
   ### What happened
   
   It's tricky to answer a simple question: How long a year? What I mean is we can't figure out how many days in one year due to leap day. The better path is to stop the unit at the day which is identical to skywalking's downsampling.
   
   There might be two subtasks here:
   
     1. Remove https://github.com/apache/skywalking-banyandb-java-client/blob/main/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Duration.java#L33-L34
     2. Add Day duration support to the server-side and update API comments accordingly.
   
   ### What you expected to happen
   
   None
   
   ### How to reproduce
   
   None
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #8948: [Bug] Unit of measure's interval should stop at Day

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8948: [Bug] Unit of measure's interval should stop at Day
URL: https://github.com/apache/skywalking/issues/8948


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org