[GitHub] [iceberg] rdblue commented on pull request #1478: Enable Hive3 builds for iceberg-mr and iceberg-hive-metastore

[GitBox <gi...@apache.org>]

rdblue commented on pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#issuecomment-702278857


   @marton-bod, we were just talking about test metastores on #1495: https://github.com/apache/iceberg/pull/1495#discussion_r498394239
   
   I think part of the problem is that this is creating a new metastore instance for each test case. That's going to take longer and doesn't catch connection leaks. That's probably also causing the issue here, where something isn't cleaned up properly. I recommend moving Metastore setup to a `@BeforeClass`, like in [`SparkTestBase`](https://github.com/apache/iceberg/blob/d8a6f7fd19025005df75e06bfa5ab7417aad803a/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java#L51).
   
   I think that would address the issue here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org