You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Luca Burgazzoli (Jira)" <ji...@apache.org> on 2020/08/18 07:50:00 UTC
[jira] [Commented] (CAMEL-14578) Reformat files at build time to
force compliance with code standards
[ https://issues.apache.org/jira/browse/CAMEL-14578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179443#comment-17179443 ]
Luca Burgazzoli commented on CAMEL-14578:
-----------------------------------------
Looks like this still scratch all the DSL format, look at [current|https://github.com/apache/camel/blob/4ea9e6c357371682b855d2d79655b41120331b7a/catalog/camel-route-parser/src/test/java/org/apache/camel/parser/java/MyChoiceRouteBuilder.java] versus [old|https://github.com/apache/camel/blob/24e7866263cd18104a8027e57bae99933095d979/catalog/camel-route-parser/src/test/java/org/apache/camel/parser/java/MyChoiceRouteBuilder.java] where the current one looks much less readable than the old one.
> Reformat files at build time to force compliance with code standards
> --------------------------------------------------------------------
>
> Key: CAMEL-14578
> URL: https://issues.apache.org/jira/browse/CAMEL-14578
> Project: Camel
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 3.5.0
>
>
> We do have a profile to check the code against the standards we want, but then as to be manually fixed. We could fail is there's a problem at build time but that slows down people and can become very annoying.
> There are plugins that do reformat the source code during the compilation phase, this should ensure that all committed code follows the standard, without causing any disturbance to the developers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)