You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/23 23:12:50 UTC
Review Request: FLUME-1870. Flume sends non-numeric values with type as
float to Ganglia causing ganglia to crash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Added code to convert the value to float, if it fails, the type is set as string.
This addresses bug FLUME-1870.
https://issues.apache.org/jira/browse/FLUME-1870
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee
Diff: https://reviews.apache.org/r/9075/diff/
Testing
-------
All unit tests pass.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1870. Flume sends non-numeric values with type as
float to Ganglia causing ganglia to crash
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/#review15635
-----------------------------------------------------------
I'm not too familiar with ganglia so will leave the review to someone else, but just tested this and it appears to work. No more message spam in /var/log/messages
- Juhani Connolly
On Jan. 23, 2013, 10:45 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9075/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 10:45 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added code to convert the value to float, if it fails, the type is set as string.
>
>
> This addresses bug FLUME-1870.
> https://issues.apache.org/jira/browse/FLUME-1870
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee
>
> Diff: https://reviews.apache.org/r/9075/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1870. Flume sends non-numeric values with type as
float to Ganglia causing ganglia to crash
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/#review15650
-----------------------------------------------------------
Ship it!
Ship It!
- Mike Percy
On Jan. 23, 2013, 10:45 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9075/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 10:45 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added code to convert the value to float, if it fails, the type is set as string.
>
>
> This addresses bug FLUME-1870.
> https://issues.apache.org/jira/browse/FLUME-1870
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee
>
> Diff: https://reviews.apache.org/r/9075/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1870. Flume sends non-numeric values with type as
float to Ganglia causing ganglia to crash
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/#review15636
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On Jan. 23, 2013, 10:45 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9075/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 10:45 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added code to convert the value to float, if it fails, the type is set as string.
>
>
> This addresses bug FLUME-1870.
> https://issues.apache.org/jira/browse/FLUME-1870
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee
>
> Diff: https://reviews.apache.org/r/9075/diff/
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1870. Flume sends non-numeric values with type as
float to Ganglia causing ganglia to crash
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9075/
-----------------------------------------------------------
(Updated Jan. 23, 2013, 10:45 p.m.)
Review request for Flume.
Changes
-------
Updated diff to handle this in case of Ganglia 3 too.
Description
-------
Added code to convert the value to float, if it fails, the type is set as string.
This addresses bug FLUME-1870.
https://issues.apache.org/jira/browse/FLUME-1870
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 8d34fee
Diff: https://reviews.apache.org/r/9075/diff/
Testing
-------
All unit tests pass.
Thanks,
Hari Shreedharan