You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2022/08/20 19:26:00 UTC

[jira] [Closed] (MSHARED-1106) Improve and simplify section handling

     [ https://issues.apache.org/jira/browse/MSHARED-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed MSHARED-1106.
-----------------------------------
    Resolution: Fixed

Fixed with  [15861dabe9d4e63bd3ff6891a0f9da59317e3443|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=15861dabe9d4e63bd3ff6891a0f9da59317e3443].

> Improve and simplify section handling
> -------------------------------------
>
>                 Key: MSHARED-1106
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1106
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl-4.0.0-M2
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: maven-reporting-impl-4.0.0-M3
>
>
> The current code has following flaws:
> * It unnecessarily uses a switch case although it could pass the depth directly
> * The anchor is placed *after* the section title which mean that if a user jumps to the anchor the section title is not visible in the browser
> Tasks:
> * Use sink's section title method with depth arg
> * Place anchor inside the section title idential to other sinks which create anchored section titles (concistency)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)