[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12453: refactor: migrate tracing core from boot-start to dubbo deployer

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #12453:
URL: https://github.com/apache/dubbo/pull/12453#discussion_r1218990567


##########
dubbo-common/src/main/java/org/apache/dubbo/config/nested/ExporterConfig.java:
##########
@@ -56,14 +55,27 @@ public static class ZipkinConfig implements Serializable {
         private String endpoint;
 
         /**
-         * Connection timeout for requests to Zipkin.
+         * Connection timeout for requests to Zipkin. (seconds)
          */
-        private Duration connectTimeout = Duration.ofSeconds(1);
+        private Integer connectTimeout = 1;

Review Comment:
   Is it possible not to change this signature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org