[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

[GitBox <gi...@apache.org>]

lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star
URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345550759
 
 
   Why all files?  Not sure I understand. Either we decide that this is incorrect behaviour and then we change _all_ files where this occurs, rather than just some of them. Or we decide it is acceptable, and then we change _none_ at all.
   
   Strictly speaking it is only on `.java` files where there I can prove unwanted side-effects from using the Javadoc introducer. The JIRA issue contains an example where you can see one such negative side-effect.
   
   On other files, e.g. `.css`, `.c`, `.js`, etc, I don't think there's any negative side-effect of using `/**`, but I just chose to include them nevertheless. It is just safer that way, for the present and for the future. For example for JavaScript files you have JSDoc (a Javadoc look-alike), which happen to also use `/**` as the introducer.
   
   FYI: The number of files changed by extension are:
   
   ```text
     .cpp             12
     .css             17
     .pass           165
     .xjava            1
     .java         24740
     .javax            1
     .hint            39
     .patch            2
     .jj               4
     .jjt              1
     .txt              7
     .c               45
     .js               8
     .aj               2
     .g                2
     .h               52
     .plist            3
     .test            27
     .m                3
     .rc               8
     .my_extension     1
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services