You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2017/08/21 16:29:36 UTC
[1/4] hbase git commit: HBASE-18623 Frequent failed to parse at EOF
warnings from WALEntryStream
Repository: hbase
Updated Branches:
refs/heads/branch-1 00a4e0697 -> 19fffacd3
refs/heads/branch-1.4 b2eb09aa2 -> c51c78469
refs/heads/branch-2 2e069df6b -> 7fef60634
refs/heads/master 192e87309 -> 70d48b113
HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/19fffacd
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/19fffacd
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/19fffacd
Branch: refs/heads/branch-1
Commit: 19fffacd3a95bc6eebd3ea3bc0d9ff0a2593e37b
Parents: 00a4e06
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Aug 18 17:13:51 2017 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Aug 21 09:29:20 2017 -0700
----------------------------------------------------------------------
.../hbase/replication/regionserver/WALEntryStream.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/19fffacd/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 4f49955..3942d23 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -233,9 +233,11 @@ public class WALEntryStream implements Iterator<Entry>, Closeable, Iterable<Entr
if (trailerSize < 0) {
if (currentPosition < stat.getLen()) {
final long skippedBytes = stat.getLen() - currentPosition;
- LOG.info("Reached the end of WAL file '" + currentPath
- + "'. It was not closed cleanly, so we did not parse " + skippedBytes
- + " bytes of data.");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Reached the end of WAL file '" + currentPath
+ + "'. It was not closed cleanly, so we did not parse " + skippedBytes
+ + " bytes of data. This is normally ok.");
+ }
metrics.incrUncleanlyClosedWALs();
metrics.incrBytesSkippedInUncleanlyClosedWALs(skippedBytes);
}
[3/4] hbase git commit: HBASE-18623 Frequent failed to parse at EOF
warnings from WALEntryStream
Posted by ap...@apache.org.
HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/70d48b11
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/70d48b11
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/70d48b11
Branch: refs/heads/master
Commit: 70d48b113e3b824e2804164e80edf01522c85272
Parents: 192e873
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Aug 18 17:13:51 2017 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Aug 21 09:29:24 2017 -0700
----------------------------------------------------------------------
.../hbase/replication/regionserver/WALEntryStream.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/70d48b11/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 4f49955..3942d23 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -233,9 +233,11 @@ public class WALEntryStream implements Iterator<Entry>, Closeable, Iterable<Entr
if (trailerSize < 0) {
if (currentPosition < stat.getLen()) {
final long skippedBytes = stat.getLen() - currentPosition;
- LOG.info("Reached the end of WAL file '" + currentPath
- + "'. It was not closed cleanly, so we did not parse " + skippedBytes
- + " bytes of data.");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Reached the end of WAL file '" + currentPath
+ + "'. It was not closed cleanly, so we did not parse " + skippedBytes
+ + " bytes of data. This is normally ok.");
+ }
metrics.incrUncleanlyClosedWALs();
metrics.incrBytesSkippedInUncleanlyClosedWALs(skippedBytes);
}
[2/4] hbase git commit: HBASE-18623 Frequent failed to parse at EOF
warnings from WALEntryStream
Posted by ap...@apache.org.
HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c51c7846
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c51c7846
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c51c7846
Branch: refs/heads/branch-1.4
Commit: c51c784697b1dc108e7ad31fdae7992b754c9430
Parents: b2eb09a
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Aug 18 17:13:51 2017 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Aug 21 09:29:23 2017 -0700
----------------------------------------------------------------------
.../hbase/replication/regionserver/WALEntryStream.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/c51c7846/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 4f49955..3942d23 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -233,9 +233,11 @@ public class WALEntryStream implements Iterator<Entry>, Closeable, Iterable<Entr
if (trailerSize < 0) {
if (currentPosition < stat.getLen()) {
final long skippedBytes = stat.getLen() - currentPosition;
- LOG.info("Reached the end of WAL file '" + currentPath
- + "'. It was not closed cleanly, so we did not parse " + skippedBytes
- + " bytes of data.");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Reached the end of WAL file '" + currentPath
+ + "'. It was not closed cleanly, so we did not parse " + skippedBytes
+ + " bytes of data. This is normally ok.");
+ }
metrics.incrUncleanlyClosedWALs();
metrics.incrBytesSkippedInUncleanlyClosedWALs(skippedBytes);
}
[4/4] hbase git commit: HBASE-18623 Frequent failed to parse at EOF
warnings from WALEntryStream
Posted by ap...@apache.org.
HBASE-18623 Frequent failed to parse at EOF warnings from WALEntryStream
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7fef6063
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7fef6063
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7fef6063
Branch: refs/heads/branch-2
Commit: 7fef60634952135a063493051220a83308d04e22
Parents: 2e069df
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Aug 18 17:13:51 2017 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Mon Aug 21 09:29:24 2017 -0700
----------------------------------------------------------------------
.../hbase/replication/regionserver/WALEntryStream.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/7fef6063/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
index 4f49955..3942d23 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
@@ -233,9 +233,11 @@ public class WALEntryStream implements Iterator<Entry>, Closeable, Iterable<Entr
if (trailerSize < 0) {
if (currentPosition < stat.getLen()) {
final long skippedBytes = stat.getLen() - currentPosition;
- LOG.info("Reached the end of WAL file '" + currentPath
- + "'. It was not closed cleanly, so we did not parse " + skippedBytes
- + " bytes of data.");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Reached the end of WAL file '" + currentPath
+ + "'. It was not closed cleanly, so we did not parse " + skippedBytes
+ + " bytes of data. This is normally ok.");
+ }
metrics.incrUncleanlyClosedWALs();
metrics.incrBytesSkippedInUncleanlyClosedWALs(skippedBytes);
}