You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 06:04:33 UTC

[GitHub] [apisix] gy09535 commented on a change in pull request #3129: feat: support linux "resolv.conf" file resolve process

gy09535 commented on a change in pull request #3129:
URL: https://github.com/apache/apisix/pull/3129#discussion_r549579267



##########
File path: apisix/init.lua
##########
@@ -43,15 +43,18 @@ if ngx.config.subsystem == "http" then
 end
 local load_balancer
 local local_conf
-local dns_resolver
 local lru_resolved_domain
 local ver_header    = "APISIX/" .. core.version.VERSION
 
 
-local function parse_args(args)
-    dns_resolver = args and args["dns_resolver"]
-    core.utils.set_resolver(dns_resolver)
-    core.log.info("dns resolver", core.json.delay_encode(dns_resolver, true))
+local function parse_args()
+    local options = {}
+    core.utils.init_dns_proxy(options)
+    if options.nameservers then

Review comment:
       I am not recognize that , their is a config  in yaml, thanks for your remind it

##########
File path: apisix/init.lua
##########
@@ -43,15 +43,18 @@ if ngx.config.subsystem == "http" then
 end
 local load_balancer
 local local_conf
-local dns_resolver
 local lru_resolved_domain
 local ver_header    = "APISIX/" .. core.version.VERSION
 
 
-local function parse_args(args)
-    dns_resolver = args and args["dns_resolver"]
-    core.utils.set_resolver(dns_resolver)
-    core.log.info("dns resolver", core.json.delay_encode(dns_resolver, true))
+local function parse_args()
+    local options = {}
+    core.utils.init_dns_proxy(options)
+    if options.nameservers then

Review comment:
       I am not recognize that , their is a config  in yaml, thanks for your remind it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org