[GitHub] [incubator-inlong] healchow commented on a change in pull request #2602: [INLONG-2600][Manager] Rename the third party cluster class name and table name

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #2602:
URL: https://github.com/apache/incubator-inlong/pull/2602#discussion_r810576451



##########
File path: inlong-manager/manager-dao/src/main/resources/generatorConfig.xml
##########
@@ -114,7 +114,7 @@
                 enableCountByExample="false" enableDeleteByExample="false"
                 enableSelectByExample="false" enableUpdateByExample="false"/>
 
-        <table tableName="cluster_info" domainObjectName="ClusterInfoEntity"
+        <table tableName="third_party_cluster" domainObjectName="ClusterInfoEntity"

Review comment:
       The `domainObjectName` should change at the same time.

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/ThirdPartyClusterInfoEntity.java
##########
@@ -23,7 +23,7 @@
 import java.util.Date;
 
 @Data
-public class ClusterInfoEntity implements Serializable {
+public class ThirdPartyClusterInfoEntity implements Serializable {

Review comment:
       Please change it to `ThirdPartyClusterEntity`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org