You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/02/11 20:01:15 UTC

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object endpoint when local catalog mode is enabled. 

Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12443


Change subject: IMPALA-7935: Disable /catalog_object endpoint when local_catalog_mode is enabled.
......................................................................

IMPALA-7935: Disable /catalog_object endpoint when
local_catalog_mode is enabled.

Remove hyperlinks pointing to the /catalog_object endpoints
when local_catalog_mode is enabled.

Testing:
Added a test in test_local_catalog to verify hyperlinks to
/catalog_object are removed.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M www/catalog.tmpl
3 files changed, 27 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4815/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 02:44:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test to test_local_catalog::TestObservability to verify
/catalog_mode endpoint is disabled when in local catalog mode.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M www/catalog.tmpl
3 files changed, 43 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/8
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test in test_local_catalog to verify /catalog_mode endpoint
is disabled.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M www/catalog.tmpl
3 files changed, 34 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 11:

Missed a test that checks for catalog object page which doesn't exist after this change.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 11
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Aug 2019 20:06:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test to test_local_catalog::TestObservability to verify
/catalog_mode endpoint is disabled when in local catalog mode.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M www/catalog.tmpl
3 files changed, 45 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/9
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py@386
PS8, Line 386:         in impalad.service.read_debug_webpage('/catalog_object')
> nit: 4 indent spaces.
Done


http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl@42
PS8, Line 42:           <!-- The /catalog_object endpoint is disabled if local_catalog_mode is used
> nit: Add a quick comment that /catalog_object is disabled in local catalog 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 19:24:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a negetive and a positive test to verify /catalog_mode endpoint
is disabled when in local catalog mode and  vice-versa.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
4 files changed, 53 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4303/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 11
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Aug 2019 20:46:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/2083/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 14:29:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a negetive and a positive test to verify /catalog_mode endpoint
is disabled when in local catalog mode and  vice-versa.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
4 files changed, 49 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/7
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4188/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 21:58:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc@109
PS7, Line 109:       // The /catalog_object endpoint is disabled if local_catalog_mode is used.
nit: add why


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@605
PS7, Line 605: execute_serially
why?


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@607
PS7, Line 607: A positive test for /catalog_ob
Instead say, check /catalog_obj endpoint is not accessible or something?


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@608
PS7, Line 608: http://localhost:25000
use the URL templates above?


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@609
PS7, Line 609:     assert 'No URI handler for &apos;/catalog_object&apos;' \
I'm confused, the description says something else? *not* in catalog mode?


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@610
PS7, Line 610:            not in response
Can you also scrape the webpage source and make sure it doesn't have a "catalog_object" anywhere?



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 15:54:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 11
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 05:28:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2092/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 01:00:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4815/


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 07:22:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4820/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 05:28:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 03:58:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a negetive and a positive test to verify /catalog_mode endpoint
is disabled when in local catalog mode and  vice-versa.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
4 files changed, 49 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/6
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
1. Added a positive test in test_local_catalog to verify /catalog_mode
endpoint is disabled.
2. Added a negative test to test_web_pages.py to check /catalog_object
is working when local_catalog mode is not set.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/custom_cluster/test_web_pages.py
M www/catalog.tmpl
4 files changed, 62 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object endpoint when local catalog mode is enabled.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object endpoint when local_catalog_mode is enabled.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2072/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 20:47:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-7935: Disable /catalog_object in local catalog mode.
           : 
> nit: Try to fit it in a single line. Something like
Done


http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@10
PS1, Line 10: since metadata is partially fetched on demand. Removed hyperlinks
            : to the /catalog_object endpoints wh
> Mention that getTCatalogObject() is not supported in LocalCatalog mode sinc
Done


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@103
PS1, Line 103: 
             :   webserver->RegisterUrlCallback("/catalog_object", "catalog_object.tmpl",
> Don't think there is any value in defining this end point when we don't sup
Done


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@544
PS1, Line 544:       }
             : 
> don't think we need to pass this. We can infer the same depending on whethe
Done


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@557
PS1, Line 557: 
> DCHECK !use_local_catalog?
Done


http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py@348
PS1, Line 348:   assert 'No URI handler for &apos;/catalog_object&apos;'\
             :          in impalad.service.read_debug_webpage('/catalog_obje
> Instead I think we should check that there is no handler for /catalog_objec
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 14:03:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test to test_local_catalog::TestObservability to verify
/catalog_mode endpoint is disabled when in local catalog mode.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
4 files changed, 78 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/11
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 11
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@103
PS4, Line 103:   if(!FLAGS_use_local_catalog) {
> I think you missed the comment part. Add a quick comment?
Done


http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@541
PS4, Line 541:   Value table_obj(kObjectType);
> Is this needed? The template file uses fqtn only when use_local_catalog is 
Yes, fqtn is only needed to call the /catalog_obj endpoint.


http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@549
PS4, Line 549:     table_obj.AddMember("name", table_name, document->GetAllocator());
             :       Value use_local_catalog(FLAGS_use_local_catalog);
             :       table_obj.AddMember("use_loca
> Why this?
This is needed because, mushtashe templates seem to not recognize variables in parent scope. Hence, it is needed to add the local_catalog variable at both Databases and Tables level to render two different parts of the template.



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 03:14:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 05:28:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test in test_local_catalog to verify /catalog_mode endpoint
is disabled.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M www/catalog.tmpl
3 files changed, 35 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12443/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4189/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 22:32:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc@109
PS7, Line 109:       // The /catalog_object endpoint is disabled if local_catalog_mode is used
> nit: add why
Done.


http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@610
PS7, Line 610: 
> Can you also scrape the webpage source and make sure it doesn't have a "cat
In fact, this test is redundant. There is already a test for checking /catalog_obj endpoint is working for both loaded and unloaded tables. Removing this.



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 18:12:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 8: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py@386
PS8, Line 386:             in impalad.service.read_debug_webpage('/catalog_object')
nit: 4 indent spaces.


http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl@42
PS8, Line 42:           {{?use_local_catalog}} {{name}} {{/use_local_catalog}}
nit: Add a quick comment that /catalog_object is disabled in local catalog mode?



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 18:50:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2084/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 15:21:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 02:44:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4290/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 20:41:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 02:44:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................

IMPALA-7935: Disable /catalog_object in local catalog mode.

getTCatalogObject() is not supported in local catalog mode
since metadata is partially fetched on demand. Removed hyperlinks
to the /catalog_object endpoints when local_catalog_mode is enabled.

Testing:
Added a test to test_local_catalog::TestObservability to verify
/catalog_mode endpoint is disabled when in local catalog mode.

Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Reviewed-on: http://gerrit.cloudera.org:8080/12443
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-http-handler.cc
M tests/custom_cluster/test_local_catalog.py
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
4 files changed, 78 insertions(+), 20 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc@100
PS3, Line 100:   if(!FLAGS_use_local_catalog)
nit: we generally use braces for multiline if blocks.

if (condition) {
.....
}

Add a comment why we disable this end-point?


http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc@540
PS3, Line 540:       if(!FLAGS_use_local_catalog){
Add a comment that this creates hrefs for /catalog_object which is disabled in local catalog mode?


http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@42
PS3, Line 42:           {{^fqtn}}
Use 2 space formatting for nested blocks to be consistent with rest of the file. (multiple places)


http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@45
PS3, Line 45: ?fqtn
This works as expected right? I see the upstream docs has something like

{{#fqtn?}}
{{/fqtn}}

https://mustache.github.io/mustache.5.html


http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@126
PS3, Line 126:   <div class="panel-heading">
             :     <a href='catalog_object?object_type=DATABASE&object_name={{name}}' id='{{name}}'>
             :       <h2 class="panel-title">{{name}}
             :       <span class="pull-right">{{num_tables}} table(s)</span></h2>
             :     </a>
Just stumbled upon this We probably need to remove this too? In which case we need to pass the "local_catalog" flag. sorry for the confusion. You may have to redo that part.



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:20:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 09:35:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12443/6/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/6/be/src/service/impala-http-handler.cc@583
PS6, Line 583:           // Creates hyperlinks for /catalog_object. This is disabled in local catalog mode
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/12443/6/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12443/6/tests/webserver/test_web_pages.py@610
PS6, Line 610: 
flake8: W292 no newline at end of file



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 21:45:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object endpoint when local catalog mode is enabled.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object endpoint when local_catalog_mode is enabled.
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-7935: Disable /catalog_object endpoint when
           : local_catalog_mode is enabled.
nit: Try to fit it in a single line. Something like

<jira>: Disable... endpoint in local catalog mode


http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@10
PS1, Line 10: Remove hyperlinks pointing to the /catalog_object endpoints
            : when local_catalog_mode is enabled.
Mention that getTCatalogObject() is not supported in LocalCatalog mode since the metadata is partially fetched on demand?


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@103
PS1, Line 103:   webserver->RegisterUrlCallback("/catalog_object", "catalog_object.tmpl",
             :       MakeCallback(this, &ImpalaHttpHandler::CatalogObjectsHandler), false);
Don't think there is any value in defining this end point when we don't support it in local_catalog mode.


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@544
PS1, Line 544:       table_obj.AddMember("use_local_catalog", FLAGS_use_local_catalog,
             :           document->GetAllocator());
don't think we need to pass this. We can infer the same depending on whether fqtn is set or not and we set it only in the local catalog mode.


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@557
PS1, Line 557:   Webserver::ArgumentMap::const_iterator object_type_arg = args.find("object_type");
DCHECK !use_local_catalog?


http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py@348
PS1, Line 348:   assert '<a href="catalog_object?object_type=TABLE&object_name='\
             :         not in impalad.service.read_debug_webpage('/catalog')
Instead I think we should check that there is no handler for /catalog_object on the coordinator (after disabling the end point like I mentioned elsewhere).



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 23:24:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4287/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 19:54:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object in local catalog mode.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode.
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@103
PS4, Line 103:   if(!FLAGS_use_local_catalog) {
I think you missed the comment part. Add a quick comment?


http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@541
PS4, Line 541:   if(!FLAGS_use_local_catalog){
Is this needed? The template file uses fqtn only when use_local_catalog is set?


http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@549
PS4, Line 549:     Value use_local_catalog(FLAGS_use_local_catalog);
             :       table_obj.AddMember("use_local_catalog", FLAGS_use_local_catalog,
             :           document->GetAllocator())
Why this?


http://gerrit.cloudera.org:8080/#/c/12443/4/tests/custom_cluster/test_web_pages.py
File tests/custom_cluster/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12443/4/tests/custom_cluster/test_web_pages.py@42
PS4, Line 42: @pytest.mark.execute_serially
            :   def test_observability(self):
            :     # Make sure /catalog_object endpoint is enabled.
            :     response = requests.get("http://localhost:25000/catalog_object")
            :     assert 'No URI handler for &apos;/catalog_object&apos;'\
            :       not in response
Why here instead of tests/webserver/test_web_pages.py ? This is dedicated to "custom_cluster" tests/


http://gerrit.cloudera.org:8080/#/c/12443/4/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/12443/4/www/catalog.tmpl@133
PS4, Line 133:       <a href='catalog_object?object_type=DATABASE&object_name={{name}}' id='{{name}}'>
I don't see why the whole {{num_tables}} should be in a href. How about something like

<h2 class="panel-title">
  {{?use_local_catalog}}
     {{name}}
  {{/use_local_catalog}}
  {{^use_local_catalog}}
     <a href .../>
  {{/use_local_catalog}}
     <span class="pull-right">{{num_tables}} table(s)</span>
</h2>



-- 
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 22:20:06 +0000
Gerrit-HasComments: Yes