You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/01/31 16:51:17 UTC

[GitHub] [knox] pzampino commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API

pzampino commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API
URL: https://github.com/apache/knox/pull/249#discussion_r373579044
 
 

 ##########
 File path: gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscoveryTest.java
 ##########
 @@ -562,6 +565,30 @@ public void testNiFiRegistryDiscoverySSL() {
     doTestNiFiRegistryDiscovery(true);
   }
 
+  @Test
+  public void testCMDiscovery() {
 
 Review comment:
   I think it would be better to separate these, as has been done with other services (e.g., testCMDiscoveryAPI(), testCMDiscoveryUI())

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services