You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "raphaelauv (via GitHub)" <gi...@apache.org> on 2023/08/07 10:13:32 UTC
[GitHub] [airflow] raphaelauv opened a new pull request, #33168: doc: EksPodOperator
raphaelauv opened a new pull request, #33168:
URL: https://github.com/apache/airflow/pull/33168
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #33168: docs: Link to `EksPodOperator` from `KubernetesPodOperator` docs
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #33168:
URL: https://github.com/apache/airflow/pull/33168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #33168: docs: Link to `EksPodOperator` from `KubernetesPodOperator` docs
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on PR #33168:
URL: https://github.com/apache/airflow/pull/33168#issuecomment-1667895265
thanks @eladkal for the review :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on a diff in pull request #33168: doc: EksPodOperator
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on code in PR #33168:
URL: https://github.com/apache/airflow/pull/33168#discussion_r1285793431
##########
docs/apache-airflow-providers-cncf-kubernetes/operators.rst:
##########
@@ -30,6 +30,8 @@ you to create and run Pods on a Kubernetes cluster.
using the
:ref:`GKEStartPodOperator <howto/operator:GKEStartPodOperator>` operator as it
simplifies the Kubernetes authorization process.
+ Or
+ :ref:`EksPodOperator <howto/operator:EksPodOperator>` operator for `AWS Elastic Kubernetes Engine <https://aws.amazon.com/eks/>`__.
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33168: doc: EksPodOperator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33168:
URL: https://github.com/apache/airflow/pull/33168#discussion_r1285683758
##########
docs/apache-airflow-providers-cncf-kubernetes/operators.rst:
##########
@@ -30,6 +30,8 @@ you to create and run Pods on a Kubernetes cluster.
using the
:ref:`GKEStartPodOperator <howto/operator:GKEStartPodOperator>` operator as it
simplifies the Kubernetes authorization process.
+ Or
+ :ref:`EksPodOperator <howto/operator:EksPodOperator>` operator for `AWS Elastic Kubernetes Engine <https://aws.amazon.com/eks/>`__.
Review Comment:
I think it requires rephrase the whole paragraph as the paragraph talks about Google Kubernetes Engine then suggests to use `GKEStartPodOperator`, suggesting `EksPodOperator` is not right for Google Kubernetes Engine users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33168: doc: EksPodOperator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33168:
URL: https://github.com/apache/airflow/pull/33168#discussion_r1285683758
##########
docs/apache-airflow-providers-cncf-kubernetes/operators.rst:
##########
@@ -30,6 +30,8 @@ you to create and run Pods on a Kubernetes cluster.
using the
:ref:`GKEStartPodOperator <howto/operator:GKEStartPodOperator>` operator as it
simplifies the Kubernetes authorization process.
+ Or
+ :ref:`EksPodOperator <howto/operator:EksPodOperator>` operator for `AWS Elastic Kubernetes Engine <https://aws.amazon.com/eks/>`__.
Review Comment:
I think it requires rephrase the whole paragraph as the paragraphs talks about Google Kubernetes Engine then suggests to use `GKEStartPodOperator` suggesting `EksPodOperator` is not right for Google Kubernetes Engine users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33168: doc: EksPodOperator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33168:
URL: https://github.com/apache/airflow/pull/33168#discussion_r1285683758
##########
docs/apache-airflow-providers-cncf-kubernetes/operators.rst:
##########
@@ -30,6 +30,8 @@ you to create and run Pods on a Kubernetes cluster.
using the
:ref:`GKEStartPodOperator <howto/operator:GKEStartPodOperator>` operator as it
simplifies the Kubernetes authorization process.
+ Or
+ :ref:`EksPodOperator <howto/operator:EksPodOperator>` operator for `AWS Elastic Kubernetes Engine <https://aws.amazon.com/eks/>`__.
Review Comment:
I think it requires rephrase the whole paragraph as the paragraph talks about Google Kubernetes Engine then suggests to use `GKEStartPodOperator` suggesting `EksPodOperator` is not right for Google Kubernetes Engine users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org