You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/02/10 20:06:34 UTC

Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-14997
    https://issues.apache.org/jira/browse/AMBARI-14997


Repository: ambari


Description
-------

Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.


Diffs
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
  ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
  ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
  ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
  ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
  ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
  ambari-web/app/models/stack_service.js 5814386 

Diff: https://reviews.apache.org/r/43427/diff/


Testing
-------

yes. manual.
mvn test - passes.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

> On Feb. 12, 2016, 3:27 p.m., Matt wrote:
> > ambari-web/app/models/stack_service.js, line 360
> > <https://reviews.apache.org/r/43427/diff/1/?file=1239726#file1239726line360>
> >
> >     May be capitalize 'c' in display name 'Advanced HAWQ check' if the other display names are shown the same way, since this is a user facing part?

Capitalized C.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review119033
-----------------------------------------------------------


On Feb. 10, 2016, 7:06 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review119033
-----------------------------------------------------------


Ship it!




Ship It!


ambari-web/app/models/stack_service.js (line 360)
<https://reviews.apache.org/r/43427/#comment180319>

    May be capitalize 'c' in display name 'Advanced HAWQ check' if the other display names are shown the same way, since this is a user facing part?


- Matt


On Feb. 10, 2016, 11:06 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 11:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review118961
-----------------------------------------------------------


Ship it!




Ship It!

- Goutam Tadi


On Feb. 10, 2016, 7:06 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review119128
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml (line 21)
<https://reviews.apache.org/r/43427/#comment180411>

    should it be hawq_check.conf (instead of hyphen)?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml (line 25)
<https://reviews.apache.org/r/43427/#comment180412>

    underscore instead of hyphen in hawq-check.cnf ?


- jun aoki


On Feb. 10, 2016, 7:06 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review119170
-----------------------------------------------------------


Ship it!




Ship It!

- Goutam Tadi


On Feb. 14, 2016, 6:26 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 6:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml ce625eb 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 6a2d9ba 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/
-----------------------------------------------------------

(Updated Feb. 14, 2016, 6:26 a.m.)


Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Changes
-------

Applied feedback


Bugs: AMBARI-14997
    https://issues.apache.org/jira/browse/AMBARI-14997


Repository: ambari


Description
-------

Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml ce625eb 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 6a2d9ba 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
  ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
  ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
  ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
  ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
  ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
  ambari-web/app/models/stack_service.js 5814386 

Diff: https://reviews.apache.org/r/43427/diff/


Testing
-------

yes. manual.
mvn test - passes.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/
-----------------------------------------------------------

(Updated Feb. 14, 2016, 12:23 a.m.)


Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Changes
-------

Applied feedback


Bugs: AMBARI-14997
    https://issues.apache.org/jira/browse/AMBARI-14997


Repository: ambari


Description
-------

Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml ce625eb 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 6a2d9ba 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
  ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
  ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
  ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
  ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
  ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
  ambari-web/app/models/stack_service.js 5814386 

Diff: https://reviews.apache.org/r/43427/diff/


Testing
-------

yes. manual.
mvn test - passes.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43427: Update gpcheck.cnf to hawq_check.cnf file

Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43427/#review119129
-----------------------------------------------------------


Ship it!




LGTM except the comments of hyphen vs underscore.

- jun aoki


On Feb. 10, 2016, 7:06 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43427/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14997
>     https://issues.apache.org/jira/browse/AMBARI-14997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests using hawq_check.cnf config file to run hawq check on clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/gpcheck-env.xml 309a0c7 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 21ab445 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 01de99a 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 2e0b6da 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 09e305f 
>   ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 4cd2d4d 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json 560e1db 
>   ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json 93d6ec1 
>   ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json d10a976 
>   ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json 170c740 
>   ambari-web/app/data/HDP2.3/site_properties.js 61cbe88 
>   ambari-web/app/models/stack_service.js 5814386 
> 
> Diff: https://reviews.apache.org/r/43427/diff/
> 
> 
> Testing
> -------
> 
> yes. manual.
> mvn test - passes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>