You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/01/02 06:19:46 UTC
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------
(Updated Jan. 2, 2019, 2:19 p.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Updated the description of the flag `--volume_gid_range` slightly.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description (updated)
-------
When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a SANDBOX_PATH volume of PARENT type, the
volume will be owned by a gid allocated from this range and have the
`setgit` bit set, and the task process will be launched with the gid
as its supplementary group to make sure it can access the volume.
Diffs (updated)
-----
docs/configuration/agent.md 330283f4e3957075dd4310de4a841feac23de36c
src/slave/flags.hpp 494ae02ab5eb365e2cda5017be573691107c3f28
src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0
Diff: https://reviews.apache.org/r/69342/diff/3/
Changes: https://reviews.apache.org/r/69342/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/#review212396
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 6, 2019, 4:22 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69342/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2019, 4:22 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When this flag is specified, if a task running as non-root user uses a
> shared persistent volume or a PARENT type SANDBOX_PATH volume, the
> volume will be owned by a gid allocated from this range and have the
> `setgit` bit set, and the task process will be launched with the gid
> as its supplementary group to make sure it can access the volume.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 330283f4e3957075dd4310de4a841feac23de36c
> src/slave/flags.hpp 494ae02ab5eb365e2cda5017be573691107c3f28
> src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0
>
>
> Diff: https://reviews.apache.org/r/69342/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/#review213098
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 6, 2019, 4:22 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69342/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2019, 4:22 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When this flag is specified, if a task running as non-root user uses a
> shared persistent volume or a PARENT type SANDBOX_PATH volume, the
> volume will be owned by a gid allocated from this range and have the
> `setgit` bit set, and the task process will be launched with the gid
> as its supplementary group to make sure it can access the volume.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 330283f4e3957075dd4310de4a841feac23de36c
> src/slave/flags.hpp 494ae02ab5eb365e2cda5017be573691107c3f28
> src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0
>
>
> Diff: https://reviews.apache.org/r/69342/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/#review213273
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 25, 2019, 6:50 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69342/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 6:50 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8810
> https://issues.apache.org/jira/browse/MESOS-8810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When this flag is specified, if a task running as non-root user uses a
> shared persistent volume or a PARENT type SANDBOX_PATH volume, the
> volume will be owned by a gid allocated from this range and have the
> `setgit` bit set, and the task process will be launched with the gid
> as its supplementary group to make sure it can access the volume.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md fa2f55f60fa6405c6534e1b5b187355c6fec0f64
> src/slave/flags.hpp c64edd09419a7a388b783e0c9db330f9783d0d7f
> src/slave/flags.cpp 2a1f3f9ca6780ffa95c67edfbb0de8bce817995c
>
>
> Diff: https://reviews.apache.org/r/69342/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------
(Updated Feb. 26, 2019, 10:50 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Minor changes.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description
-------
When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a PARENT type SANDBOX_PATH volume, the
volume will be owned by a gid allocated from this range and have the
`setgit` bit set, and the task process will be launched with the gid
as its supplementary group to make sure it can access the volume.
Diffs (updated)
-----
docs/configuration/agent.md fa2f55f60fa6405c6534e1b5b187355c6fec0f64
src/slave/flags.hpp c64edd09419a7a388b783e0c9db330f9783d0d7f
src/slave/flags.cpp 2a1f3f9ca6780ffa95c67edfbb0de8bce817995c
Diff: https://reviews.apache.org/r/69342/diff/5/
Changes: https://reviews.apache.org/r/69342/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 69342: Added an agent flag `--volume_gid_range`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69342/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 8:22 a.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Minor changes.
Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810
Repository: mesos
Description (updated)
-------
When this flag is specified, if a task running as non-root user uses a
shared persistent volume or a PARENT type SANDBOX_PATH volume, the
volume will be owned by a gid allocated from this range and have the
`setgit` bit set, and the task process will be launched with the gid
as its supplementary group to make sure it can access the volume.
Diffs (updated)
-----
docs/configuration/agent.md 330283f4e3957075dd4310de4a841feac23de36c
src/slave/flags.hpp 494ae02ab5eb365e2cda5017be573691107c3f28
src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0
Diff: https://reviews.apache.org/r/69342/diff/4/
Changes: https://reviews.apache.org/r/69342/diff/3-4/
Testing
-------
Thanks,
Qian Zhang