You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Kinga Marton (Jira)" <ji...@apache.org> on 2020/04/29 16:07:00 UTC
[jira] [Commented] (YUNIKORN-53) Use asserts for nil error checks
in test code
[ https://issues.apache.org/jira/browse/YUNIKORN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095584#comment-17095584 ]
Kinga Marton commented on YUNIKORN-53:
--------------------------------------
[~adam.antal] can you please replace the same nil checks in shim repository as well?
> Use asserts for nil error checks in test code
> ---------------------------------------------
>
> Key: YUNIKORN-53
> URL: https://issues.apache.org/jira/browse/YUNIKORN-53
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: test - smoke, test - unit
> Reporter: Wilfred Spiegelenburg
> Assignee: Adam Antal
> Priority: Minor
> Labels: newbie, pull-request-available
>
> In a lot of tests we use the construct:
> {code}
> if err != nil {
> t.Fatal("some text"
> }{code}
> We should replace that with the simple:
> {code}
> assert.NilError(t, err, "some text"){code}
> that is part of the standard assert package we already use in the test code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org