You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 00:31:49 UTC
[GitHub] [arrow] kou commented on a change in pull request #9296: ARROW-11350: [C++] Bump dependency versions
kou commented on a change in pull request #9296:
URL: https://github.com/apache/arrow/pull/9296#discussion_r564134547
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -25,35 +25,39 @@
# Abseil LTS branch, Sept 2020, Patch 2
ARROW_ABSL_BUILD_VERSION=0f3bb466b868b523cf1dc9b2aaaed65c77b28862
-ARROW_AWSSDK_BUILD_VERSION=1.8.90
+ARROW_AWSSDK_BUILD_VERSION=1.8.128
+# aws-checksums 0.1.10 has some issues it seems
Review comment:
Could you try the following?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 961edac18..e2215f886 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2803,7 +2803,8 @@ macro(build_awssdk)
${EP_LOG_OPTIONS}
URL ${AWS_CHECKSUMS_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${AWS_CHECKSUMS_STATIC_LIBRARY})
+ BUILD_BYPRODUCTS ${AWS_CHECKSUMS_STATIC_LIBRARY}
+ DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-checksums aws_checksums_ep)
externalproject_add(aws_c_event_stream_ep
@@ -2811,7 +2812,7 @@ macro(build_awssdk)
URL ${AWS_C_EVENT_STREAM_SOURCE_URL}
CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS}
BUILD_BYPRODUCTS ${AWS_C_EVENT_STREAM_STATIC_LIBRARY}
- DEPENDS aws_c_common_ep aws_checksums_ep)
+ DEPENDS aws_checksums_ep)
add_dependencies(AWS::aws-c-event-stream aws_c_event_stream_ep)
externalproject_add(awssdk_ep
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org