You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/06/14 20:34:09 UTC
[GitHub] [activemq-artemis] erwindon opened a new pull request, #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
erwindon opened a new pull request, #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113
see https://issues.apache.org/jira/browse/ARTEMIS-3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on a diff in pull request #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
Posted by GitBox <gi...@apache.org>.
erwindon commented on code in PR #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113#discussion_r898349223
##########
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/consumers.js:
##########
@@ -204,7 +204,7 @@ var Artemis;
Artemis.log.debug("navigating to consumer = " + artemisConsumer.consumer.session);
Review Comment:
<humble-voice>of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on a diff in pull request #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
Posted by GitBox <gi...@apache.org>.
erwindon commented on code in PR #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113#discussion_r898361492
##########
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/consumers.js:
##########
@@ -204,7 +204,7 @@ var Artemis;
Artemis.log.debug("navigating to consumer = " + artemisConsumer.consumer.session);
Review Comment:
updated the PR (squashed the additional changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
Posted by GitBox <gi...@apache.org>.
brusdev commented on code in PR #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113#discussion_r898098471
##########
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/consumers.js:
##########
@@ -204,7 +204,7 @@ var Artemis;
Artemis.log.debug("navigating to consumer = " + artemisConsumer.consumer.session);
Review Comment:
Should we change the log too?
```suggestion
Artemis.log.debug("navigating to consumer = " + artemisConsumer.consumer.sessionID);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev merged pull request #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
Posted by GitBox <gi...@apache.org>.
brusdev merged PR #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on a diff in pull request #4113: ARTEMIS-3858 fix navigation from consumer/producer columns of a session to those consumers/producers
Posted by GitBox <gi...@apache.org>.
erwindon commented on code in PR #4113:
URL: https://github.com/apache/activemq-artemis/pull/4113#discussion_r898349223
##########
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/consumers.js:
##########
@@ -204,7 +204,7 @@ var Artemis;
Artemis.log.debug("navigating to consumer = " + artemisConsumer.consumer.session);
Review Comment:
\<humble-voice>of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org