OpenSSL SSL engine

[Rémy Maucherat <re...@apache.org>]

Hi,

I have now committed the initial work for this new feature. Advanced SSL
functionality (renegotiation) is disabled since that was like that upstream
and I didn't dare trying to hack it yet.

Testsuite integration (I have it in my git repository
https://github.com/rmaucher/tomcat ) is convoluted and requires additional
full runs. Obviously that's not the best idea so I am not adding it yet.
Maybe using some dedicated tests that would be slightly duplicated ?

Rémy

Re: OpenSSL SSL engine

[Rémy Maucherat <re...@apache.org>]

2015-06-18 20:16 GMT+02:00 Mark Thomas <ma...@apache.org>:

> I assume it only makes sense to run the various SSL tests. We should be
> able to (possibly with a little renaming) set things up so we can filter
> test classes by name for *SSL* (or better yet *TLS*) and run them as an
> additional batch of tests in the test task in the build script.
>

Ok, +1 for separating the SSL tests, this would allow adding additional
"full" runs with them. There's some renaming work that should be done,
because the naming is not consistent enough to filter right now, some
classes have the "SSL" name but the tests don't, on other case it is the
test name and it is inside another class (ex:
TestWsWebSocketContainer.testConnectToServerEndpointSSL), and the case is
not consistent enough.

>
> As an aside, silvaus.a.o (the CI machine the Tomcat builds use) has 16
> cores. I think we can tweak the test configuration to get much faster
> results (while still keeping the code coverage data).
>
> I am thinking we create two test targets for each branch.
>
> One has 16 threads, no code coverage and runs 5 minutes after the last
> change (as per the current config)
>
> One runs daily and uses 1 thread and runs the code coverage.
>
> I'll try setting this up for trunk and if it works we can expand it.
>
> Ok.

Rémy

Re: OpenSSL SSL engine

[Mark Thomas <ma...@apache.org>]

On 18/06/2015 18:22, Rémy Maucherat wrote:
> Hi,
> 
> I have now committed the initial work for this new feature. Advanced SSL
> functionality (renegotiation) is disabled since that was like that upstream
> and I didn't dare trying to hack it yet.
> 
> Testsuite integration (I have it in my git repository
> https://github.com/rmaucher/tomcat ) is convoluted and requires additional
> full runs. Obviously that's not the best idea so I am not adding it yet.
> Maybe using some dedicated tests that would be slightly duplicated ?
> 
> Rémy

I assume it only makes sense to run the various SSL tests. We should be
able to (possibly with a little renaming) set things up so we can filter
test classes by name for *SSL* (or better yet *TLS*) and run them as an
additional batch of tests in the test task in the build script.

As an aside, silvaus.a.o (the CI machine the Tomcat builds use) has 16
cores. I think we can tweak the test configuration to get much faster
results (while still keeping the code coverage data).

I am thinking we create two test targets for each branch.

One has 16 threads, no code coverage and runs 5 minutes after the last
change (as per the current config)

One runs daily and uses 1 thread and runs the code coverage.

I'll try setting this up for trunk and if it works we can expand it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org