You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jychen7 (via GitHub)" <gi...@apache.org> on 2023/03/25 02:13:40 UTC
[GitHub] [arrow-datafusion] jychen7 opened a new pull request, #5729: feat: enable serde of arrow-schema
jychen7 opened a new pull request, #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #5729: feat: enable serde of arrow-schema
Posted by "jychen7 (via GitHub)" <gi...@apache.org>.
jychen7 commented on PR #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729#issuecomment-1510030240
> I'm not sure why we would plumb this through
@tustvold I believe you mean Datafusion does not use `serde` feature at all and asking why to include it. I think this PR would make downstream easier to use Datafusion, but I agree `serde` seems unnecessary to Datafusion.
I am going to close this PR. @houqp what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on pull request #5729: feat: enable serde of arrow-schema
Posted by "jychen7 (via GitHub)" <gi...@apache.org>.
jychen7 commented on PR #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729#issuecomment-1511922773
@houqp that makes more sense. I will close this one then
@tustvold what do you think if we add a new feature called 'serde'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #5729: feat: enable serde of arrow-schema
Posted by "houqp (via GitHub)" <gi...@apache.org>.
houqp commented on PR #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729#issuecomment-1510884622
@jychen7 the optional feature needs to be added to the features section at https://github.com/apache/arrow-datafusion/blob/64941fa99e13459a99d2ec3f15cdd997fee41988/datafusion/core/Cargo.toml#L36.
Adding it in the dependency directly will force all datafusion users to enable serde, which adds unnecessary overheads to users who don't need it.
@tustvold as @jychen7 mentioned, this is mostly a minor UX improvement to datafusion users so they don't need to find out which downstream crate to toggle a feature and manually keep the version in sync with what's pinned in datafusion. Same idea why we have the `simd` and `pyarrow` feature flag in datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5729: feat: enable serde of arrow-schema
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729#issuecomment-1508065430
Enabling features of transitive dependencies is a well documented and standard approach, I'm not sure why we would plumb this through?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 closed pull request #5729: feat: enable serde of arrow-schema
Posted by "jychen7 (via GitHub)" <gi...@apache.org>.
jychen7 closed pull request #5729: feat: enable serde of arrow-schema
URL: https://github.com/apache/arrow-datafusion/pull/5729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org