You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/18 05:16:37 UTC
[GitHub] [flink] leonardBang opened a new pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
leonardBang opened a new pull request #16525:
URL: https://github.com/apache/flink/pull/16525
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
* Fix typo from Comparision to Comparison*
## Brief change log
- Fix typo from Comparision to Comparison*
## Verifying this change
This change is already covered by existing tests, such as *(ComparableInputTypeStrategyTest, LogicalTypeSerdeTest,WindowAggregateJsonITCase)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672948600
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
Let's do it only in master. It is just a typo and not a critical bug that needs to be fixed urgently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672919174
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
I'm fine to get the hotfix in master branch, but not sure for 1.13, becuase it changes some public API (even we marked it `@Internal`). What do you think about this @twalthr ?
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
}, {
"hash" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663",
"triggerID" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d6734e084e93499fcd3a6c6c04a0654263e02ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r673936595
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
We also changed the JSON plan for a different issue recently. We do not provide any guarantees for this yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882000763
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8d6734e084e93499fcd3a6c6c04a0654263e02ef (Thu Sep 23 18:08:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672919174
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
I'm fine to get the hotfix in master branch, but not sure for 1.13, becuase it changes some public API (even we marked it `@Internal`). What do you think about this @twalthr ?
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882000763
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 (Sun Jul 18 05:21:41 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672948600
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
Let's do it only in master. It is just a typo and not a critical bug that needs to be fixed urgently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r673061552
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
Thanks @twalthr and @wuchong for the comment, If we only fix in master, it will fail when users want to load json serialized execution plan which generated from 1.13, that's why i want to backport this one
CC @godfreyhe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672948600
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
Let's do it only in master. It is just a typo and not a critical bug that needs to be fixed urgently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
}, {
"hash" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663",
"triggerID" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d6734e084e93499fcd3a6c6c04a0654263e02ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672959516
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r672919174
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
I'm fine to get the hotfix in master branch, but not sure for 1.13, becuase it changes some public API (even we marked it `@Internal`). What do you think about this @twalthr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang closed pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
leonardBang closed pull request #16525:
URL: https://github.com/apache/flink/pull/16525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
}, {
"hash" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631)
* 8d6734e084e93499fcd3a6c6c04a0654263e02ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16525:
URL: https://github.com/apache/flink/pull/16525#issuecomment-882003167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631",
"triggerID" : "7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47",
"triggerType" : "PUSH"
}, {
"hash" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663",
"triggerID" : "8d6734e084e93499fcd3a6c6c04a0654263e02ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ecdbf4b8c65b9f74575a18a436a9c9549ba6e47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20631)
* 8d6734e084e93499fcd3a6c6c04a0654263e02ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20663)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #16525: [hotfix][table-api] Fix typo from Comparision to Comparison
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #16525:
URL: https://github.com/apache/flink/pull/16525#discussion_r673948804
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/InputTypeStrategies.java
##########
@@ -172,8 +172,8 @@ public static InputTypeStrategy wildcardWithCount(ArgumentCount argumentCount) {
* argument.
*/
public static InputTypeStrategy comparable(
- ConstantArgumentCount argumentCount, StructuredComparision requiredComparision) {
- return new ComparableTypeStrategy(argumentCount, requiredComparision);
+ ConstantArgumentCount argumentCount, StructuredComparison requiredComparison) {
Review comment:
It makes sense to me, I close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org