[jira] [Commented] (YARN-8813) Improve debug messages for NM preemption of OPPORTUNISTIC containers

["Robert Kanter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642413#comment-16642413 ] 

Robert Kanter commented on YARN-8813:
-------------------------------------

The debug messages look fine to me, other than a small grammer nitpick:
 - In {{ContainersMonitorImpl}}, instead of "Update latest..." it should be "Updated latest..." because it happens after the actual update.

 

And one minor related issue that we may as well take care of while we're here:
 - In {{CGroupElasticMemoryController#getDefaultOOMHandler}}, it looks up the {{oomHandlerClass}} first, but only uses it if {{oomHandlerLocal}} is {{null}}. We can move that lookup into the if statement to save on the call in the cases where {{oomHandlerLocal}} isn't {{null}}.

>     Improve debug messages for NM preemption of OPPORTUNISTIC containers
> ------------------------------------------------------------------------
>
>                 Key: YARN-8813
>                 URL: https://issues.apache.org/jira/browse/YARN-8813
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: YARN-1011
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-8813-YARN-1011.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org