[GitHub] [druid] cryptoe commented on a diff in pull request #13974: OOM fix for running MSQ jobs with `intermediateSuperSorterStorageMaxLocalBytes` set

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #13974:
URL: https://github.com/apache/druid/pull/13974#discussion_r1147789654


##########
processing/src/main/java/org/apache/druid/frame/channel/ComposingWritableFrameChannel.java:
##########
@@ -118,14 +123,17 @@ public void close() throws IOException
   {
     if (currentIndex < writableChannelSuppliers.size()) {
       writableChannelSuppliers.get(currentIndex).get().close();
+      convertChannelSuppliersToReadOnly(currentIndex);
       currentIndex = writableChannelSuppliers.size();
     }
   }
 
   @Override
   public boolean isClosed()
   {
-    return currentIndex == writableChannelSuppliers.size();
+    return currentIndex == writableChannelSuppliers.size() || writableChannelSuppliers.get(currentIndex)

Review Comment:
   Since this class does not own the `WritableFrameChannel` which are passed by the suppliers, the passed channel might be closed, externally and hence this check . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org