You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2010/12/03 22:34:11 UTC
[jira] Created: (WICKET-3224) FileCleaner issues
FileCleaner issues
------------------
Key: WICKET-3224
URL: https://issues.apache.org/jira/browse/WICKET-3224
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Reporter: Juergen Donnerstag
I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3224) FileCleaner issues
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966961#action_12966961 ]
Martin Grigorov commented on WICKET-3224:
-----------------------------------------
Actually we do it now with: FileCleaner.destroy().
I'm working on a patch.
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3224) FileCleaner issues
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966960#action_12966960 ]
Juergen Donnerstag commented on WICKET-3224:
--------------------------------------------
do we at all need it?
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3224) FileCleaner issues
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966957#action_12966957 ]
Martin Grigorov commented on WICKET-3224:
-----------------------------------------
In current commons-io this class is deprecated.
The recommended one now is FileCleaningTracker. The problem with this one is that it starts a daemon thread that cleans the files and this thread has to be stopped on application destroy event.
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3224) FileCleaner issues
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966959#action_12966959 ]
Igor Vaynberg commented on WICKET-3224:
---------------------------------------
cant we do that in application.internaldestroy()?
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3224) FileCleaner issues
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3224.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
With r1043182 the cleaner is upgraded to its latest version from commons-io.
Now it is possible to disable it by using "getResourceSettings().setFileUploadCleaner(null)".
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5-M4
>
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3224) FileCleaner issues
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-3224:
---------------------------------------
Priority: Minor (was: Major)
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3224) FileCleaner issues
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966967#action_12966967 ]
Martin Grigorov commented on WICKET-3224:
-----------------------------------------
The problem with the thread is that Google AppEngine doesn't allow to start it.
Current FileCleaner also starts a thread when the class is loaded, i.e. when the user application wants to use file upload functionality.
It seems no one tried to upload files in GAE so far.
I'll rework it to be like ModificationWatcher so that the user can switch this off when starting threads is problematic.
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Assignee: Martin Grigorov
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3224) FileCleaner issues
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3224:
---------------------------------------
Assignee: Martin Grigorov
> FileCleaner issues
> ------------------
>
> Key: WICKET-3224
> URL: https://issues.apache.org/jira/browse/WICKET-3224
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Juergen Donnerstag
> Assignee: Martin Grigorov
> Priority: Minor
>
> I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.