You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/03/01 19:36:35 UTC
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/#review167552
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
Lines 202 (patched)
<https://reviews.apache.org/r/56571/#comment239431>
Please consider not having any service-type of service specific code in this class. All Service-Type or service specific code needs to be in the specific subclass of RangerServiceBase (such as RangerServiceTag, RangerServiceHdfs, RangerServiceKMS, RangerServiceYarn).
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 3809 (patched)
<https://reviews.apache.org/r/56571/#comment239430>
Please consider having no code specific to Service-type or Service for which default policies are being created in this class. Ideally, this class should concern itself only with managing datastore for Ranger objects.
- Abhay Kulkarni
On Feb. 24, 2017, 8:19 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56571/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:19 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1321
> https://issues.apache.org/jira/browse/RANGER-1321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1321:Provide a mechanism to create service-specific default policies
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java 3940154
> plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 8b41ae3
> security-admin/pom.xml 0fcfc5a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
>
>
> Diff: https://reviews.apache.org/r/56571/diff/3/
>
>
> Testing
> -------
>
> Test in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>