[GitHub] [maven-install-plugin] timtebeek commented on a diff in pull request #58: [MNG-6829] Replace StringUtils#isEmpty(String) & #isNotEmpty(String)

["timtebeek (via GitHub)" <gi...@apache.org>]

timtebeek commented on code in PR #58:
URL: https://github.com/apache/maven-install-plugin/pull/58#discussion_r1203931524


##########
src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java:
##########
@@ -218,7 +218,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             ArtifactType artifactType =
                     repositorySystemSession.getArtifactTypeRegistry().get(packaging);
             if (artifactType != null
-                    && StringUtils.isEmpty(classifier)
+                    && (classifier == null || classifier.isEmpty())
                     && !StringUtils.isEmpty(artifactType.getClassifier())) {

Review Comment:
   That's surprising! Usually when that happens there's some missing type attribution; I'll do a final sweep to see if it pops up again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org