You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2015/08/20 00:14:25 UTC

svn commit: r1696681 - in /webservices/axiom/trunk: implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/ systests/old-tests/src/test/java/org/apache/axiom/om/ systests/old-tests/src/test/java/org/apache/axiom/om/impl/ systests/old-te...

Author: veithen
Date: Wed Aug 19 22:14:24 2015
New Revision: 1696681

URL: http://svn.apache.org/r1696681
Log:
Don't check element local name in LLOM. We don't do this anywhere else and there is no reason to do this (actually incomplete) check just for element local names.

Removed:
    webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/om/OMBlankElementTest.java
    webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/om/impl/OMBlankElementTest.java
Modified:
    webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
    webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/soap/impl/llom/OMElementTest.java

Modified: webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java?rev=1696681&r1=1696680&r2=1696681&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java (original)
+++ webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java Wed Aug 19 22:14:24 2015
@@ -50,9 +50,6 @@ public class OMElementImpl extends OMNod
     public OMElementImpl(OMContainer parent, String localName, OMNamespace ns, OMXMLParserWrapper builder,
                     OMFactory factory, boolean generateNSDecl) {
         super(factory);
-        if (localName == null || localName.trim().length() == 0) {
-            throw new OMException("localname can not be null or empty");
-        }
         internalSetLocalName(localName);
         coreSetBuilder(builder);
         if (parent != null) {

Modified: webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/soap/impl/llom/OMElementTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/soap/impl/llom/OMElementTest.java?rev=1696681&r1=1696680&r2=1696681&view=diff
==============================================================================
--- webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/soap/impl/llom/OMElementTest.java (original)
+++ webservices/axiom/trunk/systests/old-tests/src/test/java/org/apache/axiom/soap/impl/llom/OMElementTest.java Wed Aug 19 22:14:24 2015
@@ -78,14 +78,6 @@ public class OMElementTest extends OMTes
     }
 
     public void testConstructors() {
-
-        try {
-            factory.createOMElement("", null);
-            fail("This should fail as OMElement should not be allowed to create without a local name ");
-        } catch (Exception e) {
-            assertTrue(true);
-        }
-
         assertTrue("Namespace having same information, declared in the same context, should share" +
                 " the same namespace object",
                    firstElement.getNamespace() != secondElement.getNamespace());