You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/08/24 21:20:36 UTC

[GitHub] [thrift] Jens-G commented on a diff in pull request #2619: THRIFT-4086: Add missing calls to get_true_type when generating valid…

Jens-G commented on code in PR #2619:
URL: https://github.com/apache/thrift/pull/2619#discussion_r954310838


##########
lib/java/gradle/generateTestThrift.gradle:
##########
@@ -26,6 +26,8 @@ ext.genReuseSrc = file("$buildDir/gen-javareuse")
 ext.genFullCamelSrc = file("$buildDir/gen-fullcamel")
 ext.genOptionTypeJdk8Src = file("$buildDir/gen-option-type-jdk8")
 ext.genUnsafeSrc = file("$buildDir/gen-unsafe")
+ext.genStructOrderTestASrc = file("$buildDir/resources/test/struct-order-test/a")
+ext.genStructOrderTestBSrc = file("$buildDir/resources/test/struct-order-test/b")

Review Comment:
   @Jimexist I guess @nanreh is waiting on any further comments/requests from your side? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org