You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/29 19:07:07 UTC

[GitHub] [incubator-superset] bkyryliuk opened a new pull request #9689: Fix ENABLE_ROW_LEVEL_SECURITY flag usage

bkyryliuk opened a new pull request #9689:
URL: https://github.com/apache/incubator-superset/pull/9689


   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This diff fixes the ENABLE_ROW_LEVEL_SECURITY to properly gate the row level security implmentation.
   
   It also fixes https://github.com/apache/incubator-superset/issues/9545 if used with https://github.com/apache/incubator-superset/pull/9688 for the non RLS use-cases [row level security]
   
   As mentioned before in https://github.com/apache/incubator-superset/pull/9688 AnnotationDatasource is not a proper SQLAlchemy object and is not serializable, thus attempts to do it fail.
   
   ### TEST PLAN
   * locally
   * unit tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @dpgaspar 
   @villebro 
   @altef


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #9689: Fix ENABLE_ROW_LEVEL_SECURITY flag usage

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9689:
URL: https://github.com/apache/incubator-superset/pull/9689#issuecomment-621459600


   I'm going to expedite merging these critical fixes. However, I will try to assess how this could have been avoided with good unit tests (I'm slightly surprised this evaded all existing tests).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org