[GitHub] [arrow] mapleFU commented on a diff in pull request #35422: MINOR: [C++] Use [] instead of exception-throwing at(i) in concatenate.cc

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35422:
URL: https://github.com/apache/arrow/pull/35422#discussion_r1192615733


##########
cpp/src/parquet/encryption/test_encryption_util.cc:
##########
@@ -322,7 +323,14 @@ void ReadAndVerifyColumn(RowGroupReader* rg_reader, RowGroupMetadata* rg_md,
   }
   ASSERT_EQ(rows_read, rows_should_read);
   ASSERT_EQ(values_read, rows_should_read);
-  ASSERT_EQ(read_col_data.values, expected_column_data.values);

Review Comment:
   Just curious why would you change float comparing to this. Did you found NaN here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org