You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/11 19:02:39 UTC
[GitHub] [incubator-superset] khtruong opened a new pull request #7289: fix:
propagate color mapping from dashboard to charts
khtruong opened a new pull request #7289: fix: propagate color mapping from dashboard to charts
URL: https://github.com/apache/incubator-superset/pull/7289
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
If a dashboard has a color mapping saved and the user explores a chart from the dashboard, the coloring may look different. This is because we would propagate the color scheme but not the color mapping to the chart. This change fixes this issue. The PR also sets it up for color consistency in charts and the ability to change an individual color mapping in the future.
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Tested manually
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@graceguo-supercat @kristw @williaster @betodealmeida @xtinec @DiggidyDave
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org