[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume

[GitBox <gi...@apache.org>]

DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1085516648


   > `external_uuid` is not clear for me (maybe other users), can we use other name like `virtual_disk_uuid` ?
   
   I guess your are right, the name is not really nice. But there are a couple of uuids for volumes and with virtual_disk_uuid some can assume that is the uuid that you can see in the VCenter, but it isn't. More accurate, it is the filename on the hard disk. But filename_uuid is also not pretty nice :D.
   
   Therefore "external_uuid" ... this uuid plays no role if you work in CS or VCenter but it is interesting if you want to find the file.
   
   But I see I'm a little bit inconsistent, method name and answer parameter should be the same name like the var name. :-/
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org