You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/22 11:57:02 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
KarmaGYZ opened a new pull request #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR fix the parameter issue in `retry_times` function of common.sh.
## Brief change log
Fix the parameter issue in `retry_times` function of common.sh.
## Verifying this change
Trigger container relevant e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
cc: @wangyang0918 @tillrohrmann
Since it's a blocker issue for e2e test, I open this PR without being assigned first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
tillrohrmann edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568423724
Quick question, isn't the problem that we pass the `command` in https://github.com/apache/flink/commit/cce1cef50d993aba5060ea5ac597174525ae895e as multiple strings instead of wrapping the command in `""` before we pass it to `retry_times`? If I look at `retry_times_with_backoff_and_cleanup` then one also needs to pass the `command` and `cleanup_command` as a single string (meaning one needs to wrap it into `""`). The fix seems to underline this as we are joining `${@:3}` into a single string.
The problem now is that `retry_times` and `retry_times_with_backoff_and_cleanup` behave differently wrt their parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568255767
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 778cadccf43d4558502c2fdbc19d8b069a62fe65 (Sun Dec 22 11:59:45 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15360).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142041396) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568401052
Travis passed.
cc @zhijiangW .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568256763
@tillrohrmann After https://github.com/apache/flink/commit/bdd432a09a776fec88f465771101893a8151dc1d , the retry_times function could not accept commands with multiple parts split by whitespace. This PR fix that problem. It holds the commands to a local variable and uses double quotes around this variable. So that, the commands could be accept as a single string parameter by retry_times_with_backoff_and_cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568454203
> Quick question, isn't the problem that we pass the `command` in [cce1cef](https://github.com/apache/flink/commit/cce1cef50d993aba5060ea5ac597174525ae895e) as multiple strings instead of wrapping the command in `""` before we pass it to `retry_times`? If I look at `retry_times_with_backoff_and_cleanup` then one also needs to pass the `command` and `cleanup_command` as a single string (meaning one needs to wrap it into `""`). The fix seems to underline this as we are joining `${@:3}` into a single string.
>
> The problem now is that `retry_times` and `retry_times_with_backoff_and_cleanup` behave differently wrt their parameters.
Before [bdd432](https://github.com/apache/flink/commit/bdd432a09a776fec88f465771101893a8151dc1d), `retry_times` will joining `${@:3}` into a single string. So, I think that commit changes the contract of `retry_times`, not as excepted. This PR fix that problem.
Regarding to the inconsistent parameter, I agreed it's better to align the behavior of two functions. We could work on it in future work. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568256763
After https://github.com/apache/flink/commit/bdd432a09a776fec88f465771101893a8151dc1d , the retry_times function could not accept commands with multiple parts split by whitespace. This PR fix that problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568256763
@tillrohrmann After https://github.com/apache/flink/commit/bdd432a09a776fec88f465771101893a8151dc1d , the retry_times function could not accept commands with multiple parts split by whitespace. This PR fix that problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568381131
In addition, it is better to copy some descriptions from jira ticket to the commit content. Then it would be helpful to further understand the motivation and changes of this commit. You can also submit a pr for the release-1.10 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10657: [FLINK-15360][e2e]
Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568423724
Quick question, isn't the problem that we pass the `command` in https://github.com/apache/flink/commit/cce1cef50d993aba5060ea5ac597174525ae895e as multiple strings instead of wrapping the command in `""` before we pass it to `retry_times`? If I look at `retry_times_with_backoff_and_cleanup` then one also needs to pass the `command` and `cleanup_command` as a single string (meaning one needs to wrap it into `""`). The fix seems to underline this as we are joining `${@:3}` into a single string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568379599
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258549
Travis give green light to relevant tests https://travis-ci.org/KarmaGYZ/flink/builds/628343573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:MANUAL TriggerID:568379599
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:MANUAL TriggerID:568383953
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142041396) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142041396) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568383953
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:MANUAL TriggerID:568379599
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:MANUAL TriggerID:568383953
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:MANUAL TriggerID:568379599
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142041396) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #10657: [FLINK-15360][e2e]
Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #10657: [FLINK-15360][e2e] Fix
the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568380023
Thanks for the fix @KarmaGYZ . After the travis pass, you can ping me then i would merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10657: [FLINK-15360][e2e]
Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568344886
This is really a magic code. However, i think it could work. Because when we define a new local shell variable and then pass it to the function `retry_times_with_backoff_and_cleanup`, it will be treated as one argument. If we directly pass `${@:3}` to the function, since it a shell array, they will be treated as multiple arguments in `retry_times_with_backoff_and_cleanup`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10657:
[FLINK-15360][e2e] Fix the parameter issue in retry_times
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568258494
<!--
Meta data
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:PUSH TriggerID:778cadccf43d4558502c2fdbc19d8b069a62fe65
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142041396 TriggerType:MANUAL TriggerID:568379599
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:MANUAL TriggerID:568383953
Hash:778cadccf43d4558502c2fdbc19d8b069a62fe65 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844 TriggerType:MANUAL TriggerID:568379599
-->
## CI report:
* 778cadccf43d4558502c2fdbc19d8b069a62fe65 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142041396) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services