You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ji...@apache.org on 2009/01/12 14:56:24 UTC

svn commit: r733756 - in /httpd/httpd/branches/2.2.x: ./ STATUS docs/ docs/conf/mime.types modules/proxy/mod_proxy_http.c support/ab.c support/suexec.c

Author: jim
Date: Mon Jan 12 05:56:19 2009
New Revision: 733756

URL: http://svn.apache.org/viewvc?rev=733756&view=rev
Log:
Merge r733127, r733219 from trunk:

pass a server_rec to ap_log_error on two interim response messages
 


use ap_log_rerror instead of r->server per niq's comments

Submitted by: covener
Reviewed/backported by: jim

Modified:
    httpd/httpd/branches/2.2.x/   (props changed)
    httpd/httpd/branches/2.2.x/STATUS
    httpd/httpd/branches/2.2.x/docs/   (props changed)
    httpd/httpd/branches/2.2.x/docs/conf/mime.types   (props changed)
    httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c
    httpd/httpd/branches/2.2.x/support/ab.c   (props changed)
    httpd/httpd/branches/2.2.x/support/suexec.c   (props changed)

Propchange: httpd/httpd/branches/2.2.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 12 05:56:19 2009
@@ -1 +1 @@
-/httpd/httpd/trunk:451572,611483,639005,639010,647395,657354,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414
+/httpd/httpd/trunk:451572,611483,639005,639010,647395,657354,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414,733127,733219

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=733756&r1=733755&r2=733756&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Mon Jan 12 05:56:19 2009
@@ -114,15 +114,6 @@
         trunk works
     +1 covener, niq, rpluem
 
- * mod_proxy_http: Add server_rec to ap_log_error() calls for interim
-   response messages
-    trunk 
-      http://svn.apache.org/viewvc?rev=733127&view=rev
-      http://svn.apache.org/viewvc?rev=733219&view=rev
-    2.2.x:
-      trunk works
-    +1: covener, niq, rpluem
-
   * util_script (CGI): return 504 (Gateway timeout) rather than 500
     when a script times out before returning status line/headers.
     PR 42190

Propchange: httpd/httpd/branches/2.2.x/docs/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 12 05:56:19 2009
@@ -1 +1 @@
-/httpd/httpd/trunk/docs:451572,611483,639005,639010,647395,657354,657459,660461,660566,664330,675610,678761,681190,682369,683626,684351,685112,686549,686805,686809,687099,687754,692325,693120,693392,693727-693728,696006,697093,703441,703997,706318,707163,708902,711421,719357,720250,732414
+/httpd/httpd/trunk/docs:451572,611483,639005,639010,647395,657354,657459,660461,660566,664330,675610,678761,681190,682369,683626,684351,685112,686549,686805,686809,687099,687754,692325,693120,693392,693727-693728,696006,697093,703441,703997,706318,707163,708902,711421,719357,720250,732414,733127,733219

Propchange: httpd/httpd/branches/2.2.x/docs/conf/mime.types
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 12 05:56:19 2009
@@ -1 +1 @@
-/httpd/httpd/trunk/docs/conf/mime.types:83749-721972,732414
+/httpd/httpd/trunk/docs/conf/mime.types:83749-721972,732414,733127,733219

Modified: httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c?rev=733756&r1=733755&r2=733756&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c (original)
+++ httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c Mon Jan 12 05:56:19 2009
@@ -1622,7 +1622,7 @@
              */
             const char *policy = apr_table_get(r->subprocess_env,
                                                "proxy-interim-response");
-            ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, NULL,
+            ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
                          "proxy: HTTP: received interim %d response",
                          r->status);
             if (!policy || !strcasecmp(policy, "RFC")) {
@@ -1632,7 +1632,7 @@
              * policies and maybe also add option to bail out with 502
              */
             else if (strcasecmp(policy, "Suppress")) {
-                ap_log_error(APLOG_MARK, APLOG_WARNING, 0, NULL,
+                ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
                              "undefined proxy interim response policy");
             }
         }

Propchange: httpd/httpd/branches/2.2.x/support/ab.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 12 05:56:19 2009
@@ -1 +1 @@
-/httpd/httpd/trunk/support/ab.c:83751-655654,657354,657433,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414
+/httpd/httpd/trunk/support/ab.c:83751-655654,657354,657433,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414,733127,733219

Propchange: httpd/httpd/branches/2.2.x/support/suexec.c
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 12 05:56:19 2009
@@ -1 +1 @@
-/httpd/httpd/trunk/support/suexec.c:451572,611483,639005,639010,647395,655711,657354,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414
+/httpd/httpd/trunk/support/suexec.c:451572,611483,639005,639010,647395,655711,657354,657459,660461,660566,664330,678761,681190,682369,683626,685112,686805,686809,687099,687754,693120,693392,693727-693728,696006,697093,706318,707163,708902,711421,719357,720250,732414,733127,733219

Re: svn commit: r733756 - in /httpd/httpd/branches/2.2.x: ./ STATUS docs/ docs/conf/mime.types modules/proxy/mod_proxy_http.c support/ab.c support/suexec.c

Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
 

> -----Ursprüngliche Nachricht-----
> Von: Eric Covener 
> Gesendet: Montag, 12. Januar 2009 15:02
> An: dev@httpd.apache.org
> Betreff: Re: svn commit: r733756 - in 
> /httpd/httpd/branches/2.2.x: ./ STATUS docs/ 
> docs/conf/mime.types modules/proxy/mod_proxy_http.c 
> support/ab.c support/suexec.c
> 
> On Mon, Jan 12, 2009 at 8:56 AM,  <ji...@apache.org> wrote:
> > Author: jim
> > Date: Mon Jan 12 05:56:19 2009
> > New Revision: 733756
> >
> > URL: http://svn.apache.org/viewvc?rev=733756&view=rev
> > Log:
> > Merge r733127, r733219 from trunk:
> >
> > pass a server_rec to ap_log_error on two interim response messages
> >
> >
> >
> > use ap_log_rerror instead of r->server per niq's comments
> >
> > Submitted by: covener
> > Reviewed/backported by: jim
> >
> > Modified:
> >    httpd/httpd/branches/2.2.x/   (props changed)
> >    httpd/httpd/branches/2.2.x/STATUS
> >    httpd/httpd/branches/2.2.x/docs/   (props changed)
> >    httpd/httpd/branches/2.2.x/docs/conf/mime.types   (props changed)
> >    httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c
> >    httpd/httpd/branches/2.2.x/support/ab.c   (props changed)
> >    httpd/httpd/branches/2.2.x/support/suexec.c   (props changed)
> 
> 
> I'm a bit of an svn newbie, but is this stuff that came along for the
> ride harmless?

Yeah. These are updates to the mergeinfo properties of these resources.
I don't know why this only happens on those resources. You need to
have a svn client >= 1.5.0 to have this happen I guess.

Regards

Rüdiger

Re: svn commit: r733756 - in /httpd/httpd/branches/2.2.x: ./ STATUS docs/ docs/conf/mime.types modules/proxy/mod_proxy_http.c support/ab.c support/suexec.c

Posted by Eric Covener <co...@gmail.com>.
On Mon, Jan 12, 2009 at 8:56 AM,  <ji...@apache.org> wrote:
> Author: jim
> Date: Mon Jan 12 05:56:19 2009
> New Revision: 733756
>
> URL: http://svn.apache.org/viewvc?rev=733756&view=rev
> Log:
> Merge r733127, r733219 from trunk:
>
> pass a server_rec to ap_log_error on two interim response messages
>
>
>
> use ap_log_rerror instead of r->server per niq's comments
>
> Submitted by: covener
> Reviewed/backported by: jim
>
> Modified:
>    httpd/httpd/branches/2.2.x/   (props changed)
>    httpd/httpd/branches/2.2.x/STATUS
>    httpd/httpd/branches/2.2.x/docs/   (props changed)
>    httpd/httpd/branches/2.2.x/docs/conf/mime.types   (props changed)
>    httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c
>    httpd/httpd/branches/2.2.x/support/ab.c   (props changed)
>    httpd/httpd/branches/2.2.x/support/suexec.c   (props changed)


I'm a bit of an svn newbie, but is this stuff that came along for the
ride harmless?


-- 
Eric Covener
covener@gmail.com