You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/14 04:27:51 UTC
[GitHub] [dubbo] codecov-commenter commented on pull request #9033: [3.0] Manage global resources and executor services, fix zk client connections
codecov-commenter commented on pull request #9033:
URL: https://github.com/apache/dubbo/pull/9033#issuecomment-942936380
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9033](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee2b9ef) into [3.0](https://codecov.io/gh/apache/dubbo/commit/73f7da19f4df65f1ee83827e5e98e83816233bfb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73f7da1) will **decrease** coverage by `0.14%`.
> The diff coverage is `72.62%`.
[](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9033 +/- ##
============================================
- Coverage 63.67% 63.52% -0.15%
- Complexity 312 321 +9
============================================
Files 1168 1174 +6
Lines 50183 50524 +341
Branches 7461 7488 +27
============================================
+ Hits 31953 32096 +143
- Misses 14736 14881 +145
- Partials 3494 3547 +53
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfig/configcenter/nop/NopDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9ub3AvTm9wRHluYW1pY0NvbmZpZ3VyYXRpb24uamF2YQ==) | `22.22% <0.00%> (-2.78%)` | :arrow_down: |
| [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.23% <0.00%> (-0.35%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.61% <ø> (+8.59%)` | :arrow_up: |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `42.42% <0.00%> (ø)` | |
| [...ter/support/apollo/ApolloDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L2Fwb2xsby9BcG9sbG9EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `46.98% <ø> (ø)` | |
| [...enter/support/nacos/NacosConfigServiceWrapper.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29uZmlnY2VudGVyL3N1cHBvcnQvbmFjb3MvTmFjb3NDb25maWdTZXJ2aWNlV3JhcHBlci5qYXZh) | `37.50% <0.00%> (-5.36%)` | :arrow_down: |
| [...enter/support/nacos/NacosDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29uZmlnY2VudGVyL3N1cHBvcnQvbmFjb3MvTmFjb3NEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `22.36% <0.00%> (-0.30%)` | :arrow_down: |
| [...e/dubbo/metadata/report/MetadataReportFactory.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/dubbo/qos/command/impl/ShutdownTelnet.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9TaHV0ZG93blRlbG5ldC5qYXZh) | `68.00% <0.00%> (-12.77%)` | :arrow_down: |
| [...g/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1ncnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvZ3JwYy9HcnBjUHJvdG9jb2wuamF2YQ==) | `63.52% <0.00%> (-1.54%)` | :arrow_down: |
| ... and [140 more](https://codecov.io/gh/apache/dubbo/pull/9033/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [73f7da1...ee2b9ef](https://codecov.io/gh/apache/dubbo/pull/9033?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org