You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/12/09 12:14:55 UTC

[GitHub] [opennlp] mawiesne commented on a diff in pull request #449: OPENNLP-1406 Enhance JavaDoc in opennlp.tools.parser package

mawiesne commented on code in PR #449:
URL: https://github.com/apache/opennlp/pull/449#discussion_r1044397338


##########
opennlp-tools/src/main/java/opennlp/tools/parser/ParserModel.java:
##########
@@ -41,16 +41,15 @@
 import opennlp.tools.util.model.POSModelSerializer;
 
 /**
- * This is an abstract base class for {@link ParserModel} implementations.
+ * This is the default {@link ParserModel} implementation.
  */
-// TODO: Model should validate the artifact map

Review Comment:
   No, as this is done in `ParserModel`. That's why I removed the orphaned TODO here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org